Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the bounding circle computation for polygons, introducing Welzl's algorithm for computing minimal enclosing circles and improving the bounding box calculation performance.
- Renames the original
GetBoundingCircletoGetBoundingCircleSimpleand marks it as non-minimal - Implements Welzl's algorithm for computing the true minimal bounding circle via the new
GetBoundingCirclemethod - Adds a
Circumcenterproperty that returns the center of the minimal bounding circle - Optimizes
GetBoundingBoxto avoid unnecessary object allocations and iterations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a new implementation of the
GetBoundingCircle()function to caluculate the correct minimal-bounding-circle of a polygon. The old function is still available, because it is slightly faster and a lot simpler but it does not produce minimal bounding circles (resulting circles always contain all polygon points but might be bigger than necessary).