Closed
Conversation
Added warning to EndlessSpaceCollision about current bug of updating CollisionHandler twice each frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
PhysicsObjectandCollisionObjectwould update their state in the open update function even if fixed physics framerate is enabled. ThePhysicsObjectwould update the internal physics state in the normalUpdate()function instead of theFixedUpdate()function and theCollisionObjectwould update all the colliders in theUpdate()function instead of theFixedUpdate()function.This PR introduces new
FixedModeandFixedStepproperties in theGameTimeclass, so that every function always knows if the fixed framerate system is enabled and if the currentGameTimeinstance holds fixed or open timing information.This PR also includes some fixes in some of the Example scenes that do not properly make use of
FixedUpdate(). For instance because of this I found out that theEndlessSpaceExampleSceneupdates the collision handler twice in each frame instead of only once!FixedMode/FixedStepGameTimeproperties added.GameTimeproperties.