Skip to content

CollisionPoint & CollisionPoints renamed#74

Merged
SoloByte merged 2 commits intomainfrom
collisionPoint-rename
Jul 2, 2025
Merged

CollisionPoint & CollisionPoints renamed#74
SoloByte merged 2 commits intomainfrom
collisionPoint-rename

Conversation

@SoloByte
Copy link
Collaborator

@SoloByte SoloByte commented Jul 2, 2025

Summary

This PR renames CollisionPoint to IntersectionPoint throughout the codebase. The original name reflected its use in collision response logic; however, as the codebase evolved, this structure began serving a broader purpose—representing points where shapes intersect in a variety of contexts, not limited to collisions. The new name, IntersectionPoint, more clearly describes its general role, improves readability, and reduces ambiguity for future maintainers.

Benefits:

  • More accurate and descriptive naming for current and future usage
  • Improves clarity and maintainability of the code
  • Reduces confusion for contributors unfamiliar with the original intent

No functional changes are introduced; this is a pure refactor focused on naming consistency.

Commits:

  • Refactor: CollisionPoint and CollisionPoints renamed to IntersectionPoint and IntersectionPoints. (e626844)

Refactor: CollisionPoint and CollisionPoints renamed to IntersectionPoint and IntersectionPoints.
@SoloByte SoloByte self-assigned this Jul 2, 2025
@SoloByte SoloByte requested a review from Copilot July 2, 2025 16:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors all occurrences of CollisionPoint and CollisionPoints to the more descriptive IntersectionPoint and IntersectionPoints across the codebase to better reflect their general role in shape intersection logic.

  • Renamed types, constructors, and return values from collision to intersection.
  • Updated method signatures and XML docs to reference the new names.
  • Adjusted all related drawing and geometry utilities to use the updated types.

Reviewed Changes

Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.

File Description
ShapeEngine/Geometry/TriangulationDef/…IntersectShape.cs Updated return types and docs from CollisionPoints to IntersectionPoints.
ShapeEngine/Geometry/SegmentDef/SegmentIntersectionStatic.cs Swapped CollisionPoint references to IntersectionPoint.
ShapeEngine/Geometry/StripedDrawingDef/…DrawingTriangle.cs Replaced collisionPointsReference with intersectionPointsReference.
Comments suppressed due to low confidence (1)

ShapeEngine/Geometry/SegmentDef/SegmentIntersectionStatic.cs:16

  • The doc comment still refers to "collision point"; please update it to "intersection point" for consistency.
    /// <returns>A tuple containing the <see cref="IntersectionPoint"/> and the intersection time along the first segment. If there is no intersection, the collision point is invalid and the time is -1.</returns>

@SoloByte SoloByte added documentation Improvements or additions to documentation style labels Jul 2, 2025
@SoloByte SoloByte merged commit f93db9a into main Jul 2, 2025
7 checks passed
@SoloByte SoloByte deleted the collisionPoint-rename branch July 2, 2025 16:36
@SoloByte SoloByte added this to the 5.0 milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refactor style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants