Merged
Conversation
Refactor: CollisionPoint and CollisionPoints renamed to IntersectionPoint and IntersectionPoints.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors all occurrences of CollisionPoint and CollisionPoints to the more descriptive IntersectionPoint and IntersectionPoints across the codebase to better reflect their general role in shape intersection logic.
- Renamed types, constructors, and return values from collision to intersection.
- Updated method signatures and XML docs to reference the new names.
- Adjusted all related drawing and geometry utilities to use the updated types.
Reviewed Changes
Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ShapeEngine/Geometry/TriangulationDef/…IntersectShape.cs | Updated return types and docs from CollisionPoints to IntersectionPoints. |
| ShapeEngine/Geometry/SegmentDef/SegmentIntersectionStatic.cs | Swapped CollisionPoint references to IntersectionPoint. |
| ShapeEngine/Geometry/StripedDrawingDef/…DrawingTriangle.cs | Replaced collisionPointsReference with intersectionPointsReference. |
Comments suppressed due to low confidence (1)
ShapeEngine/Geometry/SegmentDef/SegmentIntersectionStatic.cs:16
- The doc comment still refers to "collision point"; please update it to "intersection point" for consistency.
/// <returns>A tuple containing the <see cref="IntersectionPoint"/> and the intersection time along the first segment. If there is no intersection, the collision point is invalid and the time is -1.</returns>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames
CollisionPointtoIntersectionPointthroughout the codebase. The original name reflected its use in collision response logic; however, as the codebase evolved, this structure began serving a broader purpose—representing points where shapes intersect in a variety of contexts, not limited to collisions. The new name,IntersectionPoint, more clearly describes its general role, improves readability, and reduces ambiguity for future maintainers.Benefits:
No functional changes are introduced; this is a pure refactor focused on naming consistency.
Commits: