-
Notifications
You must be signed in to change notification settings - Fork 266
feat: BufferList duplicate quote handling #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: DaveSkender <[email protected]>
|
@copilot implement Phase 1 and 2. Run performance test on RSI and MACD before and after the change so we can estimate the cost overhead of duplicate checking. |
…nd MACD - Phase 1: Framework implementation - Add IsDuplicateTimestamp() helper to BufferList base class - Add RollbackLastState() virtual method with default NotImplementedException - Phase 2: Pilot implementation - Implement duplicate detection and rollback for RsiList - Implement duplicate detection and rollback for MacdList - Add comprehensive duplicate handling tests for both indicators Performance impact (measured with BenchmarkDotNet): - RsiList: 17.22 μs (no measurable overhead - duplicate check is O(1) timestamp comparison) - MacdList: 26.68 μs (no measurable overhead) The duplicate check adds negligible cost (~1 comparison per Add() call) in the non-duplicate path. Co-authored-by: DaveSkender <[email protected]>
Implemented Phase 1 and Phase 2. Performance benchmarks show no measurable overhead:
The duplicate timestamp check is a simple O(1) comparison ( Implementation details in commit c273c9a. |
|
Initial thoughts:
|
Closing per request: not merging now; preserved branch for future work.