Fix SSE integration test comparison logic to use correct series pattern

[Copilot]

Fix SSE integration test comparison logic

Following the STC reference test pattern and user guidance. All review feedback addressed.

Key Insight:
Insert/Remove operations (operations 1, 2, 3) test rollback mechanisms but DON'T change the final quote data. As the user pointed out: "If you remove a quote then add that same quote back, you obviously shouldn't attempt to add it back again."

Changes Made:

• allQuotesWithOperations in StcHub test: Simple copy of allQuotes (no modifications)
• allQuotesWithRevisions in AllHubs test: Copy of allQuotes with ONLY the index 1600 revision applied
• Using TakeLast(cacheSize) pattern from reference test
• All 79 indicator comparisons use this pattern

Operations Analysis:

1. Operation 1 (Insert(allQuotes[80])): No-op - quote already in list
2. Operation 2 (RemoveAt(100) then Insert(allQuotes[100])): No-op - remove then re-add same quote
3. Operation 3 (AllHubs: revision at index 1600): ACTUAL change - apply to allQuotesWithRevisions
4. Operation 4 (AllHubs: revisions at last quote): Final revision back to original - no net change

Review Feedback Addressed:

• Added parameter validation for SetMinCacheSize
• Fixed tail replacement state restoration bug
• Fixed self-fulfilling assertion in pruning test
• Added fail-fast for malformed SSE payloads
• Added Remove actions to SSE server rollback scenarios

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

📝 Walkthrough

Walkthrough

This pull request replaces the public StreamHub.Insert() method with Add() as the primary API for adding late-arriving data, deprecates the Insert method, removes the Insert enum member from Act, and introduces a new MinCacheSize property to track minimum cache retention requirements. A protected InsertWithoutRebuild() method is added for internal cache operations. Documentation, migration guides, and hundreds of test files are updated to reflect the API change. The SSE server is extended with scenario support for testing rollback and pruning behaviors.

Possibly related issues

• Stock.Indicators#1936 — Main changes introduce MinCacheSize property and update cache pruning tests to validate cache size after processing, which directly addresses the request for standardized cache-pruning tests across StreamHub implementations.

Possibly related PRs

• Stock.Indicators#1922 — Both PRs modify the audit script (tools/scripts/audit-streamhub.sh) to update provider-history test detection patterns, changing from Insert to Add method checks.
• Stock.Indicators#1897 — Both PRs modify StreamHub interfaces and observable types (IStreamHub, IStreamObservable, BaseProvider, StreamHub.Observable.cs) for cache access and subscription handling.
• Stock.Indicators#1906 — Both PRs modify QuotePart.StreamHub.cs code paths, adding or changing OnAdd behavior and InsertWithoutRebuild logic that depends on this PR's API refactoring.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}