Implementation of ADC for C0 (compiles but untested)#170
Draft
FeldrinH wants to merge 10 commits intoDavid-OConnor:mainfrom
Draft
Implementation of ADC for C0 (compiles but untested)#170FeldrinH wants to merge 10 commits intoDavid-OConnor:mainfrom
FeldrinH wants to merge 10 commits intoDavid-OConnor:mainfrom
Conversation
Owner
|
Hey! I love what you're doing here. I regrettably don't have a C0 to test. And, at the core of this is handling differences in both hardware, and PAC APIs. I would love to merge this after you've validated it works on hardware. I don't have immediately answers to your questions regarding design decisions; it's been a while since I touched this part of the code. I will get back to you. |
Contributor
Author
|
I hope to test this on actual C0 hardware soonish, I just haven't been to the lab and I don't have the necessary components at home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166. This is my work in progress implementation of ADC for C0. Currently it compiles but I haven't tested it on actual hardware.
Notable API changes (C0 only, no changes on other device families):
InputTypeenum.AdcInterrupt.set_sample_timeand it now sets the sample time for all channels.Breaking API changes (all device families, not just C0):
Triggerenum is now just a reexport ofEXTSELfrom the PAC. GenerallyEXTSELand the oldTriggerenum are identical except thatEXTSELsometimes uses different names for a few values (e.g.ExtiX->ExtiLineX).Open questions:
start_conversioncallset_sequence_len? It seems to me that it should, but currently it does not. Is this an undiscovered bug in all ADC implementations for all families?Triggeras a re-export ofEXTSELa good idea?