Install RuboCop and update code to pass

Author: tylerhunt

.rubocop.yml

@@ -0,0 +1,38 @@
+---
+plugins:
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+
+Lint/DuplicateBranch:
+  IgnoreLiteralBranches: true
+
+Naming/FileName:
+  Exclude:
+    - 'lib/capybara-email.rb'
+
+Metrics/AbcSize:
+  CountRepeatedAttributes: false
+
+Metrics/MethodLength:
+  CountAsOne: ['array', 'hash', 'heredoc', 'method_call']
+  Max: 15
+
+RSpec/ExampleLength:
+  Max: 10
+
+RSpec/MultipleExpectations:
+  Max: 5
+
+Style/BlockDelimiters:
+  EnforcedStyle: semantic
+
+Style/Documentation:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma

Gemfile

@@ -1,7 +1,13 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
 
-if RUBY_VERSION >= '2.0'
-  gem 'byebug'
-end
+source 'https://rubygems.org'
 
 gemspec
+
+gem 'actionmailer', '> 3.0'
+gem 'bourne'
+gem 'byebug' if RUBY_VERSION >= '2.0'
+gem 'rake'
+gem 'rspec'
+gem 'rubocop'
+gem 'rubocop-rspec'

Rakefile

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'rspec/core/rake_task'
+
 Bundler::GemHelper.install_tasks
 
 RSpec::Core::RakeTask.new('default') do |t|
   t.pattern = FileList['spec/**/*_spec.rb']
 end
-

capybara-email.gemspec

@@ -1,24 +1,23 @@
-# -*- encoding: utf-8 -*-
-require File.expand_path('../lib/capybara/email/version', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('lib/capybara/email/version', __dir__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ['Brian Cardarella']
-  gem.email         = %w([email protected] [email protected])
-  gem.description   = %q{Test your ActionMailer and Mailer messages in Capybara}
-  gem.summary       = %q{Test your ActionMailer and Mailer messages in Capybara}
-  gem.homepage      = 'https://github.com/dockyard/capybara-email'
-  gem.license       = 'MIT'
+  gem.authors = ['Brian Cardarella']
+  gem.email = %w[[email protected] [email protected]]
+  gem.description = 'Test your ActionMailer and Mailer messages in Capybara'
+  gem.summary = 'Test your ActionMailer and Mailer messages in Capybara'
+  gem.homepage = 'https://github.com/dockyard/capybara-email'
+  gem.license = 'MIT'
+  gem.required_ruby_version = '>= 2.7'
 
-  gem.files         = Dir['lib/**/*.rb', 'LICENSE', 'README.md']
-  gem.test_files    = Dir['spec/**/*.rb']
-  gem.name          = 'capybara-email'
+  gem.files = Dir['lib/**/*.rb', 'LICENSE', 'README.md']
+  gem.name = 'capybara-email'
   gem.require_paths = ['lib']
-  gem.version       = Capybara::Email::VERSION
+  gem.version = Capybara::Email::VERSION
 
-  gem.add_dependency 'mail'
   gem.add_dependency 'capybara', '>= 2.4', '< 4.0'
-  gem.add_development_dependency 'actionmailer', '> 3.0'
-  gem.add_development_dependency 'bourne'
-  gem.add_development_dependency 'rspec'
-  gem.add_development_dependency 'rake'
+  gem.add_dependency 'mail'
+
+  gem.metadata['rubygems_mfa_required'] = 'true'
 end

lib/capybara-email.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'capybara'
 require 'mail'
 

lib/capybara/email.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Capybara
   module Node
     autoload :Email,    'capybara/node/email'

lib/capybara/email/driver.rb

@@ -1,94 +1,103 @@
 # frozen_string_literal: true
-class Capybara::Email::Driver < Capybara::Driver::Base
-  attr_reader :email
 
-  def initialize(email)
-    @email = email
-  end
+module Capybara
+  module Email
+    class Driver < Capybara::Driver::Base
+      attr_reader :email
 
-  def follow(url)
-    url = URI.parse(url)
-    host = "#{url.scheme}://#{url.host}"
-    host += ":#{url.port}" unless url.port == url.default_port
-    host_with_path = File.join(host, url.path)
-    Capybara.current_session.visit([host_with_path, url.query].compact.join('?'))
-  end
+      def initialize(email)
+        @email = email
+        super()
+      end
 
-  def body
-    dom.to_xml
-  end
+      def follow(url)
+        url = URI.parse(url)
+        host = "#{url.scheme}://#{url.host}"
+        host += ":#{url.port}" unless url.port == url.default_port
+        host_with_path = File.join(host, url.path)
 
-  # Nokogiri object for traversing content
-  #
-  # @return Nokogiri::HTML::Document
-  def dom
-    @dom ||= Nokogiri::HTML(source)
-  end
+        Capybara
+          .current_session
+          .visit([host_with_path, url.query].compact.join('?'))
+      end
 
-  # Find elements based on given xpath
-  #
-  # @param [xpath string]
-  #
-  # @return [Array<Capybara::Driver::Node>]
-  def find(selector)
-    dom.xpath(selector).map { |node| Capybara::Email::Node.new(self, node) }
-  end
+      def body
+        dom.to_xml
+      end
 
-  alias_method :find_xpath, :find
+      # Nokogiri object for traversing content
+      #
+      # @return Nokogiri::HTML::Document
+      def dom
+        @dom ||= Nokogiri::HTML(source)
+      end
 
-  def find_css(selector)
-    dom.css(selector).map { |node| Capybara::Email::Node.new(self, node) }
-  end
+      # Find elements based on given xpath
+      #
+      # @param [xpath string]
+      #
+      # @return [Array<Capybara::Driver::Node>]
+      def find(selector)
+        dom.xpath(selector).map { |node| Capybara::Email::Node.new(self, node) }
+      end
 
-  # String version of email HTML source
-  #
-  # @return String
-  def source
-    if email.mime_type == 'text/plain'
-      convert_to_html(raw)
-    else
-      raw
-    end
-  end
+      alias find_xpath find
 
-  # Plain text email contents
-  #
-  # @return String
-  def raw
-    if email.mime_type =~ /\Amultipart\/(alternative|related|mixed)\Z/
-      if email.html_part
-        return email.html_part.body.to_s
-      elsif email.text_part
-        return email.text_part.body.to_s
+      def find_css(selector)
+        dom.css(selector).map { |node| Capybara::Email::Node.new(self, node) }
       end
-    end
 
-    return email.body.to_s
-  end
+      # String version of email HTML source
+      #
+      # @return String
+      def source
+        if email.mime_type == 'text/plain'
+          convert_to_html(raw)
+        else
+          raw
+        end
+      end
 
-  private
+      # Plain text email contents
+      #
+      # @return String
+      def raw
+        if email.mime_type =~ %r{\Amultipart/(alternative|related|mixed)\Z}
+          if email.html_part
+            return email.html_part.body.to_s
+          elsif email.text_part
+            return email.text_part.body.to_s
+          end
+        end
 
-  def method_missing(method_name, *args, &block)
-    if email.respond_to?(method_name)
-      if args.empty?
-        email.send(method_name)
-      else
-        email.send(method_name, args)
+        email.body.to_s
       end
-    else
-      super
-    end
-  end
 
-  def respond_to_missing?(method_name, include_private = false)
-    email.respond_to?(method_name, include_private || super)
-  end
+      private
 
-  def convert_to_html(text)
-    "<html><body>#{convert_links(text)}</body></html>"
-  end
+      def method_missing(method_name, *args)
+        if email.respond_to?(method_name)
+          if args.empty?
+            email.send(method_name)
+          else
+            email.send(method_name, args)
+          end
+        else
+          super
+        end
+      end
 
-  def convert_links(text)
-    text.gsub(%r{(https?://\S+)}, %q{<a href="\1">\1</a>})
+      def respond_to_missing?(method_name, include_private = false)
+        email.respond_to?(method_name, include_private || super)
+      end
+
+      def convert_to_html(text)
+        "<html><body>#{convert_links(text)}</body></html>"
+      end
+
+      def convert_links(text)
+        text.gsub(%r{(https?://\S+)}, %q(<a href="\1">\1</a>))
+      end
+    end
   end
 end