fix: isPictureInPictureActive needs to be updated when user exits PIP#11
Open
stacktoshi wants to merge 1 commit intoDawChihLiou:mainfrom
Open
fix: isPictureInPictureActive needs to be updated when user exits PIP#11stacktoshi wants to merge 1 commit intoDawChihLiou:mainfrom
stacktoshi wants to merge 1 commit intoDawChihLiou:mainfrom
Conversation
… using browser control
stacktoshi
commented
May 6, 2024
| } | ||
| togglePictureInPicture(true) | ||
| } | ||
| function _onLeavePictureInPicture(e: Event) { |
Author
There was a problem hiding this comment.
Since the leavepictureinpicture event doesn't use the LeavePictureInPictureEvent type, at least in my environment, I'm just using Event here. lmk if I should remove LeavePictureInPictureEvent above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is when the user clicks the restore button using browser control:
isPictureInPictureActivewasn't being updated in that case since only the toggle method from the hook return was updating it.