feat: Initial implementation of DbUp.ClickHouse#2
Conversation
|
@droyad is there anything I can do to help you with this PR? |
| <Product>DbUp</Product> | ||
| <Copyright>Copyright © DbUp Contributors 2015</Copyright> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <TargetFrameworks>netstandard2.1;net462;net48;net8.0;net9.0</TargetFrameworks> |
There was a problem hiding this comment.
Any reason we can't just target these two? It covers all frameworks listed
| <TargetFrameworks>netstandard2.1;net462;net48;net8.0;net9.0</TargetFrameworks> | |
| <TargetFrameworks>netstandard2.1;net462</TargetFrameworks> |
There was a problem hiding this comment.
Frankly I copied the whole target list from Clickhouse.Driver and I did not really want to get into the details on what optimizations they might have done for all these targets. @droyad do you think a shorter list has its advantages?
There was a problem hiding this comment.
@droyad I think you are right to question, the shorter list the less package size, and the Clickhouse.Driver itself will be linked with proper optimization regardless of dbup-clickhouse`s own target. Removed the excess
| <AssemblyOriginatorKeyFile>../dbup.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> |
There was a problem hiding this comment.
This should stay as it helps it be whitelisted and not picked up by AV
There was a problem hiding this comment.
Sure, restored that, thanks for noticing
There was a problem hiding this comment.
Oops.. We've had
error CS8002: Referenced assembly 'ClickHouse.Driver, Version=0.7.20.0, Culture=neutral, PublicKeyToken=null' does not have a strong name
Reverted it
There was a problem hiding this comment.
Ugh, so annoying. Thanks for checking.
See @droyad comment on PR DbUp#2 (comment)
Assembly signing failed because of error CS8002: Referenced assembly 'ClickHouse.Driver, Version=0.7.20.0, Culture=neutral, PublicKeyToken=null' does not have a strong name
|
I'll publish tomorrow. There are some other maintenance things that should go out at the same time. |
|
Took me a bit to get the build working. It's not quite there, but enough to at least merge this PR. |
|
It has been released! @shokurov Are you interested in being the maintainer for this provider? |
|
Yes, I am using it in production anyway. Will be glad to help. |
3 participants
Checklist
Description
Initial implementation based on official
ClickHouse.Driver, with proper test coverage.Additionally I've create integration tests to run over
TestContainers.ClickHouse. I'm not sure if this feasible for Github pipelines, but its totally worth having in local development.