Skip to content

[IMP] Better error handling when loading records #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Better error handling when loading records #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/main/java/com/odoojava/api/ObjectAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,28 @@ private void importDataV7(RowCollection rows, Object[][] importRows) throws XmlR

if (results.get("ids") instanceof Boolean) {
// There was an error. ids is false and not an Object[]
Map<String, Object>[] messages = (Map<String, Object>[]) results.get("messages");
String errorString = Arrays.stream(messages) // NOSONAR
.flatMap(m -> m.entrySet().stream())
.map(e -> String.join(":", e.getKey(), e.getValue().toString()))
.collect(Collectors.joining("\n"));
boolean std_method = true;
String errorString = "Unknown Error!";
try {
Map<String, Object>[] messages = (Map<String, Object>[]) results.get("messages");
errorString = Arrays.stream(messages) // NOSONAR
.flatMap(m -> m.entrySet().stream())
.map(e -> String.join(":", e.getKey(), e.getValue().toString()))
.collect(Collectors.joining("\n"));
} catch (Exception e) {
std_method = false;
}

if (!std_method) {
Object[] messages = (Object[]) results.get("messages");
if (messages != null && messages.length > 0) {
Object object = messages[0];
if (object instanceof Map) {
Map map = (Map) object;
errorString = map.get("message").toString();
}
}
}
throw new OdooApiException(errorString);
}

Expand Down