Merged
Conversation
✅ Deploy Preview for dearobjet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary 버튼, Secondary-1 버튼 (Light), Secondary-2 버튼 (Dark)의 상태에 따른 색상 변경 및 미리보기 추가.
Theme 색상 추가(figma design systme의 gray-100, gray-200, gray-300, gray-500, gray-700, gray-900에 해당하는 색상들) 이름은 gray가 아닌 theme-100, theme-200 이런 식으로 변경함.
색상은 rgb값을 이용해 변경하도록 함. 현재 api가 없으므로 localStorage에 저장하여 불러오는 방식을 사용중이며 값이 로딩되기 전에 기본값(fallback)이 반영되며 값을 변경후 localStorage에 저장된 값이 반영되도록 함.
변경사항 저장 버튼으로 변경사항 저장가능.
기본값 되돌리기 버튼으로 변경전 기본 값으로 되돌아감.
다크모드 추가(ThemeToggle). (다크모드는 admin이 아닌 이용자가 개인설정에서 사용할 수 있도록 변경 혹은 삭제 예정.)
이에 따른 button component의 variantClasses property 수정.
현재 markup 및 component를 따로 분리하지 않은 상태임. theme systme 적용을 위해 PR을 먼저 반영한 것으로 추후에 작업이 필요함!!