Open
Conversation
Update the template writer to create the file with the new name (`debian/salsa-ci.yml`) so that new packages automatically comply with current Salsa conventions and avoid unnecessary manual renaming. The file content remains unchanged; only the destination path is updated.
Some existing tooling and documentation still expects the GitLab CI configuration at the legacy path `debian/gitlab-ci.yml`. To avoid breaking anything while we migrate to the new standard location `debian/salsa-ci.yml`, create a compatibility file that simply includes the new configuration. This commit in its entirety can be reverted once all references to `gitlab-ci.yml` have been replaced by `salsa-ci.yml`.
rhansen
approved these changes
Feb 22, 2026
| } | ||
| defer fCompat.Close() | ||
|
|
||
| const compatContent = `# This file exists only for backwards compatibility and can be removed once if this repository CI settings have migrated to use the new file name 'salsa-ci.yml'. |
Contributor
There was a problem hiding this comment.
Wording is a bit awkward ("once if"), and the line is very long. How about something like this:
Suggested change
| const compatContent = `# This file exists only for backwards compatibility and can be removed once if this repository CI settings have migrated to use the new file name 'salsa-ci.yml'. | |
| const compatContent = `# This file exists only for backwards compatibility and can be removed once all documentation and | |
| # tools have migrated to use the new file name 'salsa-ci.yml'. |
|
|
||
| const compatContent = `# This file exists only for backwards compatibility and can be removed once if this repository CI settings have migrated to use the new file name 'salsa-ci.yml'. | ||
| include: | ||
| - local: 'debian/salsa-ci.yml' |
Contributor
There was a problem hiding this comment.
It might be worth adding a comment noting that this path is relative to the repository root, not relative to the file doing the import, and link to the GitLab documentation.
However, the GitLab documentation isn't entirely clear. The phrase "a full path relative to" is awkward—how can a full path be relative to anything? Maybe it would be better to make this an absolute path (/debian/salsa-ci.yml) to hedge against a future GitLab version that might change the behavior of relative paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details.