Merged
Conversation
- Combine and simplify build targets (`PackRez`, `PackRezConfiguration`, `TestRez`) into unified `Pack` and `Test` targets. - Introduce matrix strategy for test frameworks and runners in workflows. - Update projects to .NET 10.0 and adjust dependencies (e.g., `Roslynator.Analyzers`, `NUnit`, `Polyfill`) to latest versions. - Enhance workflows for GitHub Actions: add branch filters, matrix builds, and improved artifact management. - Standardize GitVersion configuration for better pre-release handling. - Add `.gitignore` entries for JetBrains Rider, VS Code, and workspace-specific files.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the project to .NET 10.0, however it contains critical issues as .NET 10.0 and related packages have not been released yet as of December 2025. The PR also includes test project renaming from "UnitTests" to "Tests", build system refactoring with consolidated targets, GitVersion configuration updates, and code formatting improvements.
Key Changes
- Version upgrades: Attempts to upgrade from .NET 9.0 to .NET 10.0 (not yet available)
- Test project rename: Standardizes test naming from
DecSm.Rez.UnitTeststoDecSm.Rez.Tests - Build automation refactoring: Consolidates pack/test targets and adds multi-platform testing with framework matrices
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Upgrades SDK version from 9.0.0 to 10.0.0 (version does not exist) |
| Directory.Build.props | Updates LangVersion to 14 and adds CA1873 to NoWarn list |
| _atom/_atom.csproj | Updates target framework and package versions to 10.0/2.0.0-rc.208 |
| _atom/_usings.cs | Simplifies global usings to single helper import |
| _atom/ITargets.cs | Refactors from individual Pack/Test targets to consolidated targets with arrays |
| _atom/Build.cs | Updates workflow definitions with matrix strategies for multi-platform testing |
| DecSm.Rez/DecSm.Rez.csproj | Adds net10.0 and net48 to target frameworks, updates package versions |
| DecSm.Rez.Configuration/DecSm.Rez.Configuration.csproj | Adds net10.0 and net48 targets, updates Microsoft.Extensions packages to 10.0.1 |
| DecSm.Rez.Configuration/IResolvableConfig.cs | Removes explicit 'public' keyword from interface members |
| DecSm.Rez.Tests/DecSm.Rez.Tests.csproj | Renames from UnitTests, adds multiple target frameworks, updates test packages |
| GitVersion.yml | Restructures versioning strategy with updated branch configurations and pre-release weights |
| .github/workflows/Validate.yml | Updates to consolidated targets with matrix testing across platforms |
| .github/workflows/Build.yml | Updates workflows with multi-platform matrix and artifact handling |
| .editorconfig | Converts ReSharper-prefixed rules to standard csharp_ prefixes, reduces max line length to 120 |
| .gitignore | Adds .idea and .vscode directories |
| DecSm.Rez/_usings.cs | Updates InternalsVisibleTo from UnitTests to Tests |
| DecSm.Rez.sln | Updates test project reference name |
| Multiple test files | Updates namespaces from DecSm.Rez.UnitTests to DecSm.Rez.Tests |
| Various source files | Applies formatting changes for code style consistency |
Comments suppressed due to low confidence (4)
DecSm.Rez.Tests/DecSm.Rez.Tests.csproj:20
- NUnit3TestAdapter version 6.0.0 does not exist yet. As of December 2025, the latest version of NUnit3TestAdapter is in the 5.x series. Version 6.x has not been released yet.
DecSm.Rez.Tests/DecSm.Rez.Tests.csproj:18 - Microsoft.NET.Test.Sdk version 18.0.1 does not exist. As of December 2025, the latest version of Microsoft.NET.Test.Sdk is in the 17.x series. Version 18.x has not been released yet.
DecSm.Rez.Tests/DecSm.Rez.Tests.csproj:30 - NUnit.Analyzers version 4.11.2 does not exist yet. As of December 2025, the latest version of NUnit.Analyzers is 4.10.0. Version 4.11.2 has not been released yet.
DecSm.Rez.Tests/DecSm.Rez.Tests.csproj:4 - The target framework net10.0 does not exist yet. .NET 10.0 has not been released as of December 2025. This will cause build failures. Consider removing net10.0 from the target frameworks list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Added empty `permissions` configuration for `Build` and `Validate` workflows. - Defined `contents: write` permission for `PushToRelease` job in `Build.yml`. - Updated `_atom/Build.cs` to include `GithubTokenPermissionsOption.NoneAll`. - Configured `PushToRelease` to use specific GitHub token permissions with `contents: write`.
Enhanced the build process to handle artifacts for multiple platforms and frameworks. Updated `ITargets` to dynamically select platform-framework combinations for test artifacts. Extended GitHub workflow to download artifacts for all platforms (`windows`, `ubuntu`, `macos`) and multiple .NET versions (`8.0`, `9.0`, `10.0`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.