feat: Disabling sync from non STD services to Strava

tapiriik/services/api.py

@@ -75,6 +75,7 @@ class UserExceptionType:
     UnknownTZ = "tz_unknown"
     System = "system"
     Other = "other"
+    CouldBeExternalSync = "could_be_external_sync"
 
 class UserException:
     def __init__(self, type, extra=None, intervention_required=False, clear_group=None):

tapiriik/sync/sync.py

@@ -501,13 +501,19 @@ def _getServiceExclusionUserException(self, serviceRecord):
 
     def _determineRecipientServices(self, activity):
         recipientServices = []
+        # We are getting the name of service wich the activity is from
+        activity_origin_svc_name = next((svc.Service.ID for svc in self._serviceConnections if {svc._id} & activity.ServiceDataCollection.keys()))
         for conn in self._serviceConnections:
             if not conn.Service.ReceivesActivities:
                 # Nope.
                 continue
             if conn._id in activity.ServiceDataCollection:
                 # The activity record is updated earlier for these, blegh.
                 continue
+            if activity_origin_svc_name != "decathlon" and conn.Service.ID == "strava":
+                # We don't want services other than Decathlon to send activties to Strava
+                activity.Record.MarkAsNotPresentOn(conn, UserException(UserExceptionType.CouldBeExternalSync))
+                continue
             elif hasattr(conn, "SynchronizedActivities") and len([x for x in activity.UIDs if x in conn.SynchronizedActivities]):
                 continue
             elif activity.Type not in conn.Service.SupportedActivities:

tapiriik/web/static/js/tapiriik-ng.js

@@ -39,7 +39,8 @@ function ActivitiesController($scope, $http) {
       "tz_unknown": "The time zone of this activity could not be determined.",
       "system": "There was a system error while synchronizing this activity.",
       "other": "There was an error while synchronizing this activity or this service does not support upload",
-      "unknown": "Your guess is as good as mine."
+      "unknown": "Your guess is as good as mine.",
+      "could_be_external_sync": "Services with direct synchronisation (ie : Strava and Garmin) are no longer supported as it could provoke duplicates"
     };
     return explanations[type].replace(/%\(service\)/g, $scope.DisplayNameByService(presc.Service));
   };