feat(AdditionnalRef): implement multi ref#6
Open
jlore-decathlon wants to merge 3 commits intoDecathlon:mainfrom
Open
feat(AdditionnalRef): implement multi ref#6jlore-decathlon wants to merge 3 commits intoDecathlon:mainfrom
jlore-decathlon wants to merge 3 commits intoDecathlon:mainfrom
Conversation
|
|
jlore-decathlon
changed the title
|
bump @GregoireW. |
mveroone
reviewed
Feb 1, 2025
| log.info("[{}/{}] ref found is {}, computed status is {}", deployment.getMetadata().getNamespace(), deployment.getMetadata().getName(), ref, status); | ||
|
|
||
| updateGhd(deployment, kobj.getMetadata(), status, ref); | ||
| updateGhd(deployment, dynamicKubernetesObjects.get(0).getMetadata(), status, ref); |
There was a problem hiding this comment.
Shouldn't you compute the boolean product of all elements of the array instead of taking the first one ? that seems to defeat the purpose ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4