Skip to content

State variable can be set to immutable output fixed #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

State variable can be set to immutable output fixed #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7feac48
state variable rule
h1kk4 May 31, 2023
7f3379c
add rule
h1kk4 May 31, 2023
4ae3df9
tests fix
h1kk4 May 31, 2023
7d2fdfd
Merge branch 'master' into state-variable-can-be-set-to-immutable-out…
Raz0r Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,4 @@ use-prefix-increment-not-postfix | The prefix increment expression is cheaper in
use-short-revert-string | Shortening revert strings to fit in 32 bytes will decrease gas costs for deployment and gas costs when the revert condition has been met.
non-payable-constructor | Consider making costructor payable to save gas.
non-optimal-variables-swap | Consider swapping variables using `($VAR1, $VAR2) = ($VAR2, $VAR1)` to save gas.
state-variable-can-be-set-to-immutable | Consider making variable constant or immutable to save gas.
126 changes: 126 additions & 0 deletions solidity/performance/state-variable-can-be-set-to-immutable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
pragma solidity >=0.7.4;



contract T1{
//ruleid: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
return true;
}
}

contract T2{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1 = v1 + 1;
}
}

contract T3{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1 += 1;
}
}

contract T4{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1 -= 1;
}
}

contract T5{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1 /= 1;
}
}

contract T6{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1 *= 1;
}
}

contract T7{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1++;
}
}

contract T8{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

function test() public{
v1--;
}
}

contract T9{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 1;

constructor(){
v1--;
}
}


contract T10{
//ok: state-variable-can-be-set-to-immutable
uint public immutable v1 = 1;
}

contract T11{
//ok: state-variable-can-be-set-to-immutable
uint immutable v1 = 1;
}

contract T12{
//ok: state-variable-can-be-set-to-immutable
uint constant v1 = 1;
}



// semgrep can't catch it correctly now


// contract T13{
// //ok: state-variable-can-be-set-to-immutable
// uint v1 = 1;
// }

// contract T13Child is T12{
// function test() public{
// v1 = 2;
// }
// }



contract T14{
//ok: state-variable-can-be-set-to-immutable
uint v1 = 5;
function kek() {
v1%=10;
}
}
123 changes: 123 additions & 0 deletions solidity/performance/state-variable-can-be-set-to-immutable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
rules:
- id: state-variable-can-be-set-to-immutable
metadata:
references:
- https://twitter.com/0xAsm0d3us/status/1518960501983936512
category: performance
tags:
- variable
message: Consider making variable $VARIABLE constant or immutable to save gas.
languages:
- solidity
severity: INFO
patterns:
- pattern: |
$TYPE $VARIABLE = $VALUE;
- pattern-inside: |
contract $CONTRACT{
...
$TYPE $VARIABLE = $VALUE;
...
}
- pattern-not-inside: |
contract $CONTRACT{
...
$TYPE immutable $VARIABLE = $VALUE;
...
}
- pattern-not-inside: |
contract $CONTRACT{
...
$TYPE constant $VARIABLE = $VALUE;
...
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE = $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE += $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE -= $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE *= $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE /= $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE %= $NEWVALUE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE++;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
++$VARIABLE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
--$VARIABLE;
...
}
}
- pattern-not-inside: |
contract $CONTRACT{
...
function $FUNC(...){
...
$VARIABLE--;
...
}
}