Skip to content

update detect rules #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update detect rules #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a72fcd
изменено: solidity/arbitrary-low-level-call.yaml
sh4m2hwz Aug 21, 2022
0c3ada0
новый файл: solidity/default_visibility.sol
sh4m2hwz Aug 21, 2022
bf599b2
новый файл: solidity/potensial_reentrancy.yaml
sh4m2hwz Aug 21, 2022
546678e
изменено: solidity/default_visibility.yaml
sh4m2hwz Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions solidity/arbitrary-low-level-call.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ rules:
- pattern: $ADDR.call($DATA);
- pattern: $ADDR.call{$VALUE:...}($DATA);
- pattern: $ADDR.call{$VALUE:..., $GAS:...}($DATA);
- pattern: $ADDR.call.value($VALUE)($DATA);
languages:
- solidity
severity: ERROR
Expand Down
9 changes: 9 additions & 0 deletions solidity/default_visibility.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
contract Vuln {
function f1() {}
function f2(uint a) payable returns (uint256) {

}
function f3() private {

}
}
68 changes: 68 additions & 0 deletions solidity/default_visibility.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
rules:
-
id: default_visibility
patterns:
- pattern-inside: |
function $F(...) {
...
}
- pattern-not-inside: |
function $F(...) private {
...
}
- pattern-not-inside: |
function $F(...) internal {
...
}
- pattern-not-inside: |
function $F(...) external {
...
}
- pattern-not-inside: |
function $F(...) public {
...
}
- pattern-not-inside: |
function $F(...) {
require(<... msg.sender == owner ...>);
...
}
- pattern-not-inside: |
- pattern-not-inside: function $F(...) onlyOwner { ... }
- pattern-not-inside: function $F(...) onlyVault { ... }
- pattern-not-inside: function $F(...) onlyMinter { ... }
- pattern-not-inside: function $F(...) onlyBridge { ... }
- pattern-not-inside: function $F(...) onlyOperator { ... }
- pattern-not-inside: function $F(...) onlyFactory { ... }
- pattern-not-inside: function $F(...) onlyAdmin { ... }
- pattern-not-inside: function $F(...) onlyController { ... }
- pattern-not-inside: function $F(...) hasMintBurnRole { ... }
- pattern-not-inside: function $F(...) onlyBondlyStaking { ... }
- pattern-not-inside: function $F(...) onlyApproved { ... }
- pattern-not-inside: function $F(...) onlyTrusted { ... }
- pattern-not-inside: function $F(...) onlyAdminOrOwner { ... }
- pattern-not-inside: function $F(...) onlyOwnerOrMinter { ... }
- pattern-not-inside: function $F(...) onlyMinterAndOwner { ... }
- pattern-not-inside: function $F(...) onlyValidator { ... }
- pattern-not-inside: function $F(...) onlyCore { ... }
- pattern-not-inside: function $F(...) onlyMarket { ... }
- pattern-not-inside: function $F(...) requiresTrust { ... }
- pattern-not-inside: function $F(...) onlyOpeth { ... }
- pattern-not-inside: function $F(...) onlyGovernance { ... }
- pattern-not-inside: function $F(...) onlyStaking { ... }
- pattern-not-inside: function $F(...) onlyDAO { ... }
- pattern-not-inside: function $F(...) onlyBurner(from) { ... }
- pattern-not-inside: function $F(...) onlyBurner { ... }
- pattern-not-inside: function $F(...) auth { ... }
- pattern-not-inside: function $F(...) isBridge { ... }
- pattern-not-inside: function $F(...) managerOnly { ... }
- pattern-not-inside: function $F(...) onlyHasRole(BURNER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(BURNER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(MINTER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(DEFAULT_ADMIN_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyBy(treasuryPoolAddress) { ... }
- pattern-not-inside: function $F(...) onlyBy(farmingPoolAddress) { ... }

message: function $F has default visibility
languages: [solidity]
severity: ERROR
67 changes: 67 additions & 0 deletions solidity/potensial_reentrancy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
rules:
-
id: potensial_reentrancy
patterns:
- pattern-not-inside: function $F(...) onlyOwner { ... }
- pattern-not-inside: function $F(...) onlyVault { ... }
- pattern-not-inside: function $F(...) onlyMinter { ... }
- pattern-not-inside: function $F(...) onlyBridge { ... }
- pattern-not-inside: function $F(...) onlyOperator { ... }
- pattern-not-inside: function $F(...) onlyFactory { ... }
- pattern-not-inside: function $F(...) onlyAdmin { ... }
- pattern-not-inside: function $F(...) onlyController { ... }
- pattern-not-inside: function $F(...) hasMintBurnRole { ... }
- pattern-not-inside: function $F(...) onlyBondlyStaking { ... }
- pattern-not-inside: function $F(...) onlyApproved { ... }
- pattern-not-inside: function $F(...) onlyTrusted { ... }
- pattern-not-inside: function $F(...) onlyAdminOrOwner { ... }
- pattern-not-inside: function $F(...) onlyOwnerOrMinter { ... }
- pattern-not-inside: function $F(...) onlyMinterAndOwner { ... }
- pattern-not-inside: function $F(...) onlyValidator { ... }
- pattern-not-inside: function $F(...) onlyCore { ... }
- pattern-not-inside: function $F(...) onlyMarket { ... }
- pattern-not-inside: function $F(...) requiresTrust { ... }
- pattern-not-inside: function $F(...) onlyOpeth { ... }
- pattern-not-inside: function $F(...) onlyGovernance { ... }
- pattern-not-inside: function $F(...) onlyStaking { ... }
- pattern-not-inside: function $F(...) onlyDAO { ... }
- pattern-not-inside: function $F(...) onlyBurner(from) { ... }
- pattern-not-inside: function $F(...) onlyBurner { ... }
- pattern-not-inside: function $F(...) auth { ... }
- pattern-not-inside: function $F(...) isBridge { ... }
- pattern-not-inside: function $F(...) managerOnly { ... }
- pattern-not-inside: function $F(...) onlyHasRole(BURNER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(BURNER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(MINTER_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyRole(DEFAULT_ADMIN_ROLE) { ... }
- pattern-not-inside: function $F(...) onlyBy(treasuryPoolAddress) { ... }
- pattern-not-inside: function $F(...) onlyBy(farmingPoolAddress) { ... }
- pattern-not-inside: function $F(...) nonReentrant {...}
- pattern-not-inside: function $F(...) callerIsUser {...}
- pattern-not-inside: |
function $F(...) {
...
require(tx.origin == msg.sender);
...
}
- pattern-either:
- pattern-inside: |
function $F(address $ADDR) {
...
}
- pattern-inside: |
function $F(...) {
...
}
- pattern-either:
- pattern: $ADDR.call{value:...}(...);
- pattern: $ADDR.call.value(...)(...);
- pattern: msg.sender.call{value:...}(...);
- pattern: msg.sender.call.value(...)(...);
message: potensial reentrancy in function $F
options:
symbolic_propagation: true
languages:
- solidity
severity: ERROR

18 changes: 18 additions & 0 deletions solidity/potential_reentrancy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
contract Vuln {
function f() isBridge {
msg.sender.call.value(5 ether)("");
}
function f(address a) onlyOwner {
a.call.value(5 ether)("");
}
function fn() private {
msg.sender.call.value(5 ether)("");
}
function fbb() {
address a = msg.sender;
a.call{value:5}("ff");
}
function fcc() nonReentrant {
msg.sender.call{value: msg.value}("");
}
}