-
Notifications
You must be signed in to change notification settings - Fork 26
moving pytables to conda install only, dropping python 3.9 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MMathisLab
wants to merge
12
commits into
main
Choose a base branch
from
MMathisLab-pytables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b73e9c7
Update test_and_deploy.yml
MMathisLab ff4bc6f
Update test_and_deploy.yml
MMathisLab 080f6f1
Update test_and_deploy.yml
MMathisLab 6d2b7dc
Update setup.cfg
MMathisLab 7cbaea6
Update tox.ini
MMathisLab 23e095c
Update test_and_deploy.yml
MMathisLab 7a3b1f3
Update test_and_deploy.yml
MMathisLab acde60a
Update test_and_deploy.yml
MMathisLab 7ec0c10
Update test_and_deploy.yml
MMathisLab a9a2ddb
Update test_and_deploy.yml
MMathisLab e18d87d
Update .github/workflows/test_and_deploy.yml
MMathisLab e3b38b2
Update test_and_deploy.yml
MMathisLab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,4 +1,4 @@ | ||||||
# This workflows will upload a Python Package using Twine when a release is created | ||||||
# This workflow will upload a Python Package using Twine when a release is created | ||||||
# For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries | ||||||
|
||||||
name: tests | ||||||
|
@@ -28,7 +28,7 @@ jobs: | |||||
strategy: | ||||||
matrix: | ||||||
platform: [ubuntu-latest, windows-latest, macos-latest] | ||||||
python-version: [3.9, "3.10"] | ||||||
python-version: ["3.10"] | ||||||
|
||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
|
@@ -38,39 +38,67 @@ jobs: | |||||
with: | ||||||
python-version: ${{ matrix.python-version }} | ||||||
|
||||||
# these libraries enable testing on Qt on linux | ||||||
# These libraries enable testing on Qt on linux | ||||||
- uses: tlambert03/setup-qt-libs@v1 | ||||||
|
||||||
# strategy borrowed from vispy for installing opengl libs on windows | ||||||
# Strategy borrowed from vispy for installing opengl libs on Windows | ||||||
- name: Install Windows OpenGL | ||||||
if: runner.os == 'Windows' | ||||||
run: | | ||||||
git clone --depth 1 https://github.com/pyvista/gl-ci-helpers.git | ||||||
powershell gl-ci-helpers/appveyor/install_opengl.ps1 | ||||||
if (Test-Path -Path "C:\Windows\system32\opengl32.dll" -PathType Leaf) {Exit 0} else {Exit 1} | ||||||
|
||||||
# note: if you need dependencies from conda, considering using | ||||||
# setup-miniconda: https://github.com/conda-incubator/setup-miniconda | ||||||
# and | ||||||
# tox-conda: https://github.com/tox-dev/tox-conda | ||||||
- name: Install dependencies | ||||||
# Set up Miniconda | ||||||
- name: Set up Miniconda | ||||||
uses: conda-incubator/setup-miniconda@v2 | ||||||
with: | ||||||
miniconda-version: "latest" | ||||||
auto-update-conda: true | ||||||
python-version: ${{ matrix.python-version }} | ||||||
|
||||||
- name: Create and activate environment (Linux/macOS) | ||||||
if: runner.os != 'Windows' | ||||||
run: | | ||||||
source $HOME/miniconda/etc/profile.d/conda.sh | ||||||
conda create --name test-env python=${{ matrix.python-version }} -y | ||||||
source activate test-env | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should fix the failing activate
Suggested change
|
||||||
conda install -c conda-forge pytables==3.8.0 -y | ||||||
python -m pip install --upgrade pip | ||||||
python -m pip install setuptools tox tox-gh-actions | ||||||
|
||||||
# this runs the platform-specific tests declared in tox.ini | ||||||
- name: Test with tox | ||||||
uses: aganders3/headless-gui@v2 | ||||||
with: | ||||||
run: python -m tox | ||||||
- name: Create and activate environment (Windows) | ||||||
if: runner.os == 'Windows' | ||||||
run: | | ||||||
C:\Miniconda\Scripts\conda.exe create --name test-env python=${{ matrix.python-version }} -y | ||||||
C:\Miniconda\Scripts\activate test-env | ||||||
C:\Miniconda\Scripts\conda.exe install -c conda-forge pytables==3.8.0 -y | ||||||
python -m pip install --upgrade pip | ||||||
python -m pip install setuptools tox tox-gh-actions | ||||||
|
||||||
# This runs the platform-specific tests declared in tox.ini | ||||||
- name: Test with tox (Linux/macOS) | ||||||
if: runner.os != 'Windows' | ||||||
run: | | ||||||
source $HOME/miniconda/etc/profile.d/conda.sh | ||||||
conda activate test-env | ||||||
python -m tox | ||||||
env: | ||||||
PLATFORM: ${{ matrix.platform }} | ||||||
|
||||||
- name: Test with tox (Windows) | ||||||
if: runner.os == 'Windows' | ||||||
run: | | ||||||
C:\Miniconda\Scripts\activate test-env | ||||||
python -m tox | ||||||
env: | ||||||
PLATFORM: ${{ matrix.platform }} | ||||||
|
||||||
- name: Coverage | ||||||
uses: codecov/codecov-action@v4 | ||||||
|
||||||
deploy: | ||||||
# this will run when you have tagged a commit, starting with "v*" | ||||||
# This will run when you have tagged a commit, starting with "v*" | ||||||
# and requires that you have put your twine API key in your | ||||||
# github secrets (see readme for details) | ||||||
needs: [test] | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.