Skip to content

chore: add checker to detect request.POST method after is_valid() check#143

Merged
sourya-deepsource merged 3 commits intoDeepSourceCorp:masterfrom
MashyBasker:checker/post-after-isvalid
Apr 7, 2025
Merged

chore: add checker to detect request.POST method after is_valid() check#143
sourya-deepsource merged 3 commits intoDeepSourceCorp:masterfrom
MashyBasker:checker/post-after-isvalid

Conversation

@MashyBasker
Copy link
Contributor

Test logs:

echo "Testing built-in rules..."
Testing built-in rules...
./bin/globstar test -d checkers/
Running test case: avoid_add.yml
Running test case: avoid_latest.yml
Running test case: avoid_sudo.yml
Running test case: dangerous_eval.yml
Running test case: avoid-marksafe.yml
Running test case: context-autoescape-off.yml
Running test case: filter-issafe.yml
Running test case: format-html-param.yml
Running test case: post-after-isvalid.yml
Running test case: safe-string-extend.yml
All tests passed        globstar.dev/cmd/globstar               coverage: 0.0% of statements
        globstar.dev/pkg/cli            coverage: 0.0% of statements
        globstar.dev/pkg/config         coverage: 0.0% of statements
ok      globstar.dev/pkg/analysis       0.006s  coverage: 22.7% of statements
Total coverage: 13.9%

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
@vercel
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
globstar ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 8:45am

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
@sourya-deepsource sourya-deepsource merged commit 71d72ef into DeepSourceCorp:master Apr 7, 2025
3 checks passed
unnxt30 pushed a commit to unnxt30/globstar that referenced this pull request Apr 21, 2025
…ck (DeepSourceCorp#143)

* chore: add checker to detect request.POST method after is_valid() check

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>

* chore: refine checker message

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>

* chore: improve checker message, description + add test case

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>

---------

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Unnat Sharma <officialunnat30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants