fix: fix analysis and test runners#151
Merged
sanket-deepsource merged 4 commits intomasterfrom Feb 28, 2025
Merged
Conversation
Signed-off-by: Sourya Vatsyayan <sourya@deepsource.io>
Signed-off-by: Sourya Vatsyayan <sourya@deepsource.io>
Signed-off-by: Sourya Vatsyayan <sourya@deepsource.io>
sanket-deepsource
requested changes
Feb 28, 2025
Contributor
sanket-deepsource
left a comment
sanket-deepsource
left a comment
There was a problem hiding this comment.
Suggested some renames.
| } | ||
|
|
||
| func RunAnalyzers(path string, analyzers []*Analyzer) ([]*Issue, error) { | ||
| func RunAnalyzers(path string, analyzers []*Analyzer, fileFilter func(string) bool) ([]*Issue, error) { |
Contributor
There was a problem hiding this comment.
Assuming the Analyzer refers to a checker here, can we rename this to RunCheckers?
checkers/checker.go
Outdated
| func LoadYamlRules() (map[analysis.Language][]analysis.YmlRule, error) { | ||
| rulesMap := make(map[analysis.Language][]analysis.YmlRule) | ||
| err := fs.WalkDir(builtinCheckers, ".", func(path string, d fs.DirEntry, err error) error { | ||
| func ymlRuleFinder(rulesMap map[analysis.Language][]analysis.YmlRule) func(path string, d fs.DirEntry, err error) error { |
Contributor
There was a problem hiding this comment.
The functions name should be an active verb. Can we rename this?
pkg/analysis/analyze.go
Outdated
| ana.issuesRaised = append(ana.issuesRaised, issue) | ||
| } | ||
|
|
||
| func RunYmlRules(path string, analyzers []*Analyzer) ([]*Issue, error) { |
Contributor
There was a problem hiding this comment.
We're using the term checkers. Can we rename this?
|
|
||
| checkers := cmd.String("checkers") | ||
| if checkers == "local" { | ||
| return c.RunLints(patternRules, false) |
Contributor
There was a problem hiding this comment.
Can we rename this to RunCheckers?
Signed-off-by: Sourya Vatsyayan <sourya@deepsource.io>
sanket-deepsource
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
Type of change
Checklist
checkersdirectorymake testall)Related Issues
Additional Notes