feat: allow excluding checkers with directive comment#185
Merged
sourya-deepsource merged 3 commits intoDeepSourceCorp:masterfrom Mar 28, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
MashyBasker
force-pushed
the
feat/allow-exclude-checker
branch
from
60187cd to
72a348b
Compare
ccoVeille
previously requested changes
Mar 28, 2025
MashyBasker
force-pushed
the
feat/allow-exclude-checker
branch
from
5fcfb54 to
80c66a1
Compare
sourya-deepsource
requested changes
Mar 28, 2025
sourya-deepsource
approved these changes
Mar 28, 2025
sourya-deepsource
dismissed
ccoVeille’s stale review
Changes made w.r.t comments. Thanks for the suggestions.
sourya-deepsource
merged commit b965649
into
DeepSourceCorp:master
8 of 9 checks passed
unnxt30
pushed a commit
to unnxt30/globstar
that referenced
this pull request
Apr 21, 2025
…#185) Some checkers don't report issues in code. Rather, they form the basis for other checkers to run. For example, a checker may generate the scope graph for the entire source code (or a single file), and other checkers may use the results of such "meta" checkers. We need to exclude such "meta" checkers from being run like other normal checkers. Hence, introducing the directive `//globstar:registry-exclude`. Signed-off-by: Unnat Sharma <officialunnat30@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the comment
//registry:excludeat the top of a Go checker will exclude it.