refactor(#38): merge the yaml runtime into the new analysis framework

analysis/language.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"strings"
 
 	sitter "github.com/smacker/go-tree-sitter"
 
@@ -83,6 +84,66 @@ const (
 	LangSwift
 )
 
+func DecodeLanguage(language string) Language {
+	language = strings.ToLower(language)
+	switch language {
+	case "javascript", "js":
+		return LangJs
+	case "typescript", "ts":
+		return LangTs
+	case "jsx", "tsx":
+		return LangTsx
+	case "python", "py":
+		return LangPy
+	case "ocaml", "ml":
+		return LangOCaml
+	case "docker", "dockerfile":
+		return LangDockerfile
+	case "java":
+		return LangJava
+	case "kotlin", "kt":
+		return LangKotlin
+	case "rust", "rs":
+		return LangRust
+	case "ruby", "rb":
+		return LangRuby
+	case "lua":
+		return LangLua
+	case "yaml", "yml":
+		return LangYaml
+	case "sql":
+		return LangSql
+	case "css", "css3":
+		return LangCss
+	case "markdown", "md":
+		return LangMarkdown
+	case "sh", "bash":
+		return LangBash
+	case "csharp", "cs":
+		return LangCsharp
+	case "elixir", "ex":
+		return LangElixir
+	case "elm":
+		return LangElm
+	case "go":
+		return LangGo
+	case "groovy":
+		return LangGroovy
+	case "hcl", "tf":
+		return LangHcl
+	case "html":
+		return LangHtml
+	case "php":
+		return LangPhp
+	case "scala":
+		return LangScala
+	case "swift":
+		return LangSwift
+	default:
+		return LangUnknown
+	}
+}
+
 // tsGrammarForLang returns the tree-sitter grammar for the given language.
 // May return `nil` when `lang` is `LangUnkown`.
 func (lang Language) Grammar() *sitter.Language {
@@ -169,7 +230,7 @@ func LanguageFromFilePath(path string) Language {
 		return LangYaml
 	case ".css":
 		return LangCss
-	case ".dockerfile":
+	case ".dockerfile", ".Dockerfile":
 		return LangDockerfile
 	case ".md":
 		return LangMarkdown

analysis/scope.go

@@ -147,9 +147,9 @@ func buildScopeTree(
 	if builder.NodeCreatesScope(node) {
 		nextScope = NewScope(scope)
 		scopeOfNode[node] = nextScope
-		scope.AstNode = node
 		if scope != nil {
 			scope.Children = append(scope.Children, nextScope)
+			scope.AstNode = node
 		} else {
 			scope = nextScope // root
 		}

analysis/testdata/mock-checker.yml

@@ -0,0 +1,11 @@
+language: javascript
+name: mock-checker
+message: "This is just a mock checker"
+category: style
+severity: info
+pattern: 
+  (call_expression) @mock-checker
+description: |
+  This is a mock checker.
+
+

analysis/testdata/node-filter-checker.yml

@@ -0,0 +1,9 @@
+language: javascript
+name: node-filter-checker
+message: "Variable @var found inside function"
+category: style
+severity: info
+pattern: (variable_declarator) @var @node-filter-checker
+filters:
+  - pattern-inside: (function_declaration)
+description: "Check for variables declared inside functions"

analysis/testdata/node-filter-test-checker.test.js

@@ -0,0 +1,10 @@
+console.log("Hello, world!");
+
+function foo(){
+    // <expect-error>
+    console.log("This should be detected");
+
+    /*
+    console.log("This Should not be detected");
+    */
+}

analysis/testdata/node-filter-test-checker.yml

@@ -0,0 +1,15 @@
+language: javascript
+name: node-filter-test-checker
+message: "Variable @var found inside function"
+category: style
+severity: info
+pattern: >
+  (call_expression
+    function: (member_expression
+      object: (identifier) @obj
+      property: (property_identifier) @method
+      (#eq? @obj "console"))) @node-filter-test-checker
+filters:
+  - pattern-inside: (function_declaration)
+  - pattern-not-inside: (comment)
+description: "Check for variables declared inside functions"

analysis/testrunner.go

@@ -210,6 +210,13 @@ func RunAnalyzerTests(testDir string, analyzers []*Analyzer) (string, string, bo
 
 	// if there's a test file in the testDir for which there's no analyzer,
 	// it's most likely a YAML checker test, so skip it
+
+	// yamlAnalyzers, err := discoverYamlAnalyzers(testDir)
+	// if err != nil {
+	// 	return "", "", false, err
+	// }
+	// analyzers = append(analyzers, yamlAnalyzers...)
+
 	likelyTestFiles := []string{}
 	for _, analyzer := range analyzers {
 		likelyTestFiles = append(likelyTestFiles, fmt.Sprintf("%s.test%s", analyzer.Name, GetExtFromLanguage(analyzer.Language)))