fix: rename core modules to dt_ prefix to resolve namespace collisions#125
Merged
avernikoz merged 3 commits intoDeeptradeProtocol:mainfrom Jan 5, 2026
Merged
fix: rename core modules to dt_ prefix to resolve namespace collisions#125avernikoz merged 3 commits intoDeeptradeProtocol:mainfrom
avernikoz merged 3 commits intoDeeptradeProtocol:mainfrom
Conversation
bathord
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the internal modules
math,order, andpooltodt_math,dt_order, anddt_poolrespectively.Reasoning:
This is a workaround to bypass a known Sui Move compiler bug where automated address management (using
0x0inMove.toml) causes namespace collisions when dependencies (like DeepBook) define modules with identical names.References:
math,order, andpoolmodules.Summary of Diff
The changes affect 34 files, primarily updating module declarations and their corresponding imports in both source files and test suites:
math.move→dt_mathorder.move→dt_orderpool.move→dt_poolfee.move,fee_manager.move,helper.move, and all associated unit tests.