Small modifications to one-click #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@commit111 the custom stuff actually looks great. I changed a line in the custom one to highlight the value: make it easy for other people to deploy your project. I found it a bit awkward to tell people go find a way to URL encode their link. I added my little component where they can paste anything in to URL encode it. We can actually pretty easily generate a lot of this stuff based on a link to a repo. Last week I started building little components for that (paste your repo url we'll show you all the different links at different steps), but I'll leave them out for now.
In the using 1-click I felt like the bit about logging in was a bit awkward: the title was require permissions, but the big image was of creating a repo. I felt it was more clear split into two steps. I also resized the images. Docusaurus styling defaults to having images stretch across the width of the page, but that's really awkward for small screenshots.
I also updated the screenshot of the samples to use the new design from the homepage.