BYOC MCP Prompts #281
BYOC MCP Prompts #281
Conversation
KevyVo
requested review from
lionello,
jordanstephens,
Prakash-Sundaresan and
tokifyi
docs/tutorials/deploy-to-aws.mdx
Outdated
| ``` | ||
|
|
||
| ## Step 2 - Authenticate Defang to use your AWS Account | ||
| ### Step 2 - Authenticate Defang to use your AWS Account |
There was a problem hiding this comment.
I'm not sure about this "Authenticate Defang " terminology - should it be something like "Allow Defang to use your AWS Account"? (similar for other cloud providers)
There was a problem hiding this comment.
Hmm, the word “Authenticate” was already there before, so I thought I’d just leave it. But in this case, we’re not really authenticating with Defang—we’re authenticating into AWS so that Defang can use your credentials.
I think this wording works better: “Allow Defang to use your AWS Account.” It’s simpler and easier to understand for readers at all levels.
docs/tutorials/deploy-to-aws.mdx
Outdated
| ## Step 2 - Authenticate Defang to use your AWS Account | ||
| ### Step 2 - Authenticate Defang to use your AWS Account | ||
|
|
||
| There are many ways to authenticate your [AWS account](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-authentication.html). |
There was a problem hiding this comment.
We are missing a 'with' - "There are many ways to authenticate with your..."
docs/tutorials/deploy-to-aws.mdx
Outdated
| * or, the AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_REGION arguments | ||
|
|
||
| ### Step 3 - Deploy | ||
| Once the prompt completes without errors, your chat input will be automatically populated with the deployment command for the LLM to execute. |
There was a problem hiding this comment.
I think we should replace "LLM" in this sentence with "IDE".
docs/tutorials/deploy-to-gcp.mdx
Outdated
| ``` | ||
|
|
||
| ## Step 2 - Authenticate Defang to use your GCP Account | ||
| ### Step 2 - Authenticate Defang to use your GCP Account |
There was a problem hiding this comment.
I'm not sure about this "Authenticate Defang " terminology - should it be something like "Allow Defang to use your GCP Account"?
| ## Step 2 - Authenticate Defang to use your GCP Account | ||
| ### Step 2 - Authenticate Defang to use your GCP Account | ||
|
|
||
| After signing in to your GCP account, select an existing project or [create a new project](https://developers.google.com/workspace/guides/create-project). Make sure [billing is enabled](https://cloud.google.com/billing/docs/how-to/modify-project). Then, note down the project ID and set it as environment variable `GCP_PROJECT_ID`. |
There was a problem hiding this comment.
Do we need a link to instructions on how to sign in to the GCP account (similar to how we have that for AWS)?
There was a problem hiding this comment.
Well not really because we have a list of pre recs and they have to have all that to be able to use this feature. Unless you think we should point that out specifically here.
https://github.com/DefangLabs/defang-docs/pull/281/files#diff-1eba8d9c0631215162beb78c17860fd9be34a65ec489fa858da41f2bfd21c7e2R10-R16
docs/tutorials/deploy-to-gcp.mdx
Outdated
|  | ||
| ::: | ||
|
|
||
| ### Step 2 - Authenticate Defang to use your GCP Account |
There was a problem hiding this comment.
There are 2 step 2's.
Also, this step is missing in the AWS/MCP section above - shouldn't either both have it or neither?
Yes, we are going to update the mcp.md in a different PR based on the time to release. |
|
@KevyVo why update it in a separate PR? |
I did not create any new files besides adding images. I am not sure if this best place to add the instruction for BYOC MCP prompts but I extended the existing tutorials. I am welcoming any feedback, there is better place to put it.
Tech Debt: updated Railpack doc of supported providers
Related to this PR: DefangLabs/defang#1409