Skip to content

Commit 3df55c4

Browse files
authored
fix(gcp): subtract clock skew to estimate preview (#1461)
1 parent c87c90b commit 3df55c4

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/pkg/cli/estimate.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ func RunEstimate(ctx context.Context, project *compose.Project, client client.Fa
4040
}
4141

4242
func GeneratePreview(ctx context.Context, project *compose.Project, client client.FabricClient, previewProvider client.Provider, estimateProviderID client.ProviderID, mode defangv1.DeploymentMode, region string) (string, error) {
43-
os.Setenv("DEFANG_JSON", "1") // HACK: always show JSON output for estimate
44-
since := time.Now()
43+
os.Setenv("DEFANG_JSON", "1") // HACK: always show JSON output for estimate
44+
since := time.Now().Add(-1 * time.Minute) // fetch logs since one minute ago to account for clock drift
4545

4646
fixedProject := project.WithoutUnnecessaryResources()
4747
if err := compose.FixupServices(ctx, previewProvider, fixedProject, compose.UploadModeEstimate); err != nil {
@@ -68,14 +68,14 @@ func GeneratePreview(ctx context.Context, project *compose.Project, client clien
6868

6969
term.Info("Generating deployment preview, this may take a few minutes...")
7070
var pulumiPreviewLogLines []string
71-
options := TailOptions{
71+
tailOptions := TailOptions{
7272
Deployment: resp.Etag,
73-
Since: since,
7473
LogType: logs.LogTypeBuild,
74+
Since: since,
7575
Verbose: true,
7676
}
7777

78-
err = streamLogs(ctx, previewProvider, project.Name, options, func(entry *defangv1.LogEntry, options *TailOptions) error {
78+
err = streamLogs(ctx, previewProvider, project.Name, tailOptions, func(entry *defangv1.LogEntry, options *TailOptions) error {
7979
if strings.HasPrefix(entry.Message, "Preview succeeded") {
8080
return io.EOF
8181
} else if strings.HasPrefix(entry.Message, "Preview failed") {

0 commit comments

Comments
 (0)