Skip to content

Add --until for BYOC #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 7, 2025
Merged

Add --until for BYOC #1042

merged 11 commits into from
Mar 7, 2025

Conversation

lionello
Copy link
Member

@lionello lionello commented Mar 6, 2025 •
edited
Loading

Description

Linked Issues

Fixes #459

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

@lionello lionello marked this pull request as draft March 6, 2025 01:53
@lionello lionello requested a review from edwardrf March 6, 2025 01:53
@lionello lionello marked this pull request as ready for review March 6, 2025 22:31
edwardrf
edwardrf reviewed Mar 6, 2025
View reviewed changes
edwardrf
edwardrf approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@edwardrf edwardrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionello lionello merged commit ad28a85 into main Mar 7, 2025
12 checks passed
@lionello lionello deleted the lio/log-until branch August 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardrf edwardrf edwardrf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit logging DX
3 participants
@lionello @edwardrf @edw-defang