assume host mode for postgres short ports #1445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanstephens
commented
Sep 18, 2025
Comment on lines
+28
to
+31
| - mode: ingress | ||
| target: 5432 | ||
| published: "5432" | ||
| protocol: tcp |
There was a problem hiding this comment.
@lionello should this include the fixup or not?
nullfunc
reviewed
Sep 18, 2025
jordanstephens
force-pushed
the
jordan/postgres-ports-default-host-mode
branch
from
eb0c6a2 to
b7dedb5
Compare
lionello
requested changes
Sep 19, 2025
| @@ -2,6 +2,8 @@ | |||
| ! service "no-ext": stateful service will lose data on restart; use a managed service instead | |||
| ! service "no-ports": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors | |||
| ! service "no-ports-override": missing memory reservation; using provider-specific defaults. Specify deploy.resources.reservations.memory to avoid out-of-memory errors | |||
| ! service "short-ports": ingress port without healthcheck defaults to GET / HTTP/1.1 | |||
There was a problem hiding this comment.
this warning is shown because the fixup happens too late
There was a problem hiding this comment.
Afaict this test doesn't consider fixup
jordanstephens
commented
Sep 19, 2025
jordanstephens
commented
Sep 19, 2025
jordanstephens
force-pushed
the
jordan/postgres-ports-default-host-mode
branch
from
3a1122b to
0255976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assuming host mode for short-form ports in compose file for postgres
Linked Issues
Checklist