Skip to content

assume host mode for postgres short ports #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2025
Merged

assume host mode for postgres short ports #1445

merged 7 commits into from
Sep 23, 2025

Conversation

jordanstephens
Copy link
Member

Description

Assuming host mode for short-form ports in compose file for postgres

Linked Issues

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

jordanstephens
jordanstephens commented Sep 18, 2025
View reviewed changes
nullfunc
nullfunc reviewed Sep 18, 2025
View reviewed changes
@jordanstephens jordanstephens force-pushed the jordan/postgres-ports-default-host-mode branch from eb0c6a2 to b7dedb5 Compare September 18, 2025 23:45
lionello
lionello requested changes Sep 19, 2025
View reviewed changes
jordanstephens
jordanstephens commented Sep 19, 2025
View reviewed changes
jordanstephens
jordanstephens commented Sep 19, 2025
View reviewed changes
@jordanstephens jordanstephens force-pushed the jordan/postgres-ports-default-host-mode branch from 3a1122b to 0255976 Compare September 19, 2025 22:09
lionello
lionello reviewed Sep 23, 2025
View reviewed changes
lionello
lionello requested changes Sep 23, 2025
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defang up from this branch does show this warning, but it shouldn't:

 ! service "short-ports": ingress port without healthcheck defaults to GET / HTTP/1.1

@jordanstephens jordanstephens force-pushed the jordan/postgres-ports-default-host-mode branch from d5ed531 to 0255976 Compare September 23, 2025 18:15
lionello
lionello approved these changes Sep 23, 2025
View reviewed changes
lionello
lionello reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it

lionello
lionello reviewed Sep 23, 2025
View reviewed changes
lionello
lionello reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue

@lionello lionello merged commit 3f24ead into main Sep 23, 2025
13 checks passed
@lionello lionello deleted the jordan/postgres-ports-default-host-mode branch September 23, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionello lionello lionello approved these changes

@nullfunc nullfunc Awaiting requested review from nullfunc nullfunc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanstephens @lionello @nullfunc