Fix installation to work with bash and all versions of shell #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
reviewed
Nov 15, 2024
lionello
approved these changes
Nov 16, 2024
jordanstephens
approved these changes
Nov 18, 2024
lionello
approved these changes
Nov 19, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: A better version of this is #878
Replaced the Shell installation
. <(curl -Ls https://s.defang.io/install)witheval "$(curl -Ls https://s.defang.io/install)"to fix the issue of process substitution not being available on older versions of Bash.There was discussion on other alternatives:
. /dev/stdin <<<"$(curl -Ls https://s.defang.io/install)"- good but a little long-lookingcurl -Ls https://s.defang.io/install | sh- cannot use defang immediately without refreshing after 1st installIf you have any opinion on which command to use, please comment below.
Linked Issues
Fixes #631
Updated /defang-docs repo DefangLabs/defang-docs#115
Updated /samples repo DefangLabs/samples#258
Updated /docs-chatbot repo DefangLabs/docs-chatbot#19
Checklist