Skip to content

Fix bash shell installation to use eval #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix bash shell installation to use eval #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d52e08a
fix bash install to use eval
commit111 Nov 18, 2024
20c5696
added f and S flags to curl
commit111 Nov 20, 2024
9396cd7
remove http from url in curl
commit111 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-sample.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Run Checks
id: checks
run: |
. <(curl -Ls https://s.defang.io/install)
eval "$(curl -fsSL s.defang.io/install)"
./scripts/check-sample-files.sh > checklist.txt
./scripts/check-modified-samples.sh > modified.txt
echo "@@ MODIFIED @@"
Expand All @@ -31,7 +31,7 @@ jobs:
# once we figure out how to prevent it from erroring on warnings.
# - name: Validate Compose Files with Defang CLI
# run: |
# . <(curl -Ls https://s.defang.io/install)
# eval "$(curl -fsSL s.defang.io/install)"
# cat modified.txt | xargs -n1 defang compose config -C > /dev/null

- name: Add checklist to PR description
Expand Down
2 changes: 1 addition & 1 deletion samples/nextjs-documentation/app/pages/getting-started/installing.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ brew install defang-io/defang/defang
You can install the Defang CLI using a bash script. Just run the following command in your terminal:

```bash
. <(curl -Ls https://s.defang.io/install)
eval "$(curl -fsSL s.defang.io/install)"
```

The script will try to download the appropriate binary for your operating system and architecture, add it to `~/.local/bin`, and add `~/.local/bin` to your `PATH` if it's not already there, with your permission. If you do not provide permission it will print an appropriate instruction for you to follow to add it manually. You can also customize the installation directory by setting the `INSTALL_DIR` environment variable before running the script.
Expand Down
2 changes: 1 addition & 1 deletion samples/vllm/ui/src/app/docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ brew install defang-io/defang/defang
You can install the Defang CLI using a bash script. Just run the following command in your terminal:

```bash
. <(curl -Ls https://s.defang.io/install)
eval "$(curl -fsSL s.defang.io/install)"
```

The script will try to download the appropriate binary for your operating system and architecture, add it to `~/.local/bin`, and add `~/.local/bin` to your `PATH` if it's not already there, with your permission. If you do not provide permission it will print an appropriate instruction for you to follow to add it manually. You can also customize the installation directory by setting the `INSTALL_DIR` environment variable before running the script.
Expand Down
Loading