use full aws model name for default #381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullfunc
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
| environment: | ||
| - ENDPOINT_URL=http://llm/api/v1/chat/completions # endpoint to the gateway service | ||
| - MODEL=anthropic.claude-3-haiku-20240307-v1:0 # LLM model ID used for the gateway | ||
| - MODEL=us.amazon.nova-micro-v1:0 # LLM model ID used for the gateway |
There was a problem hiding this comment.
Shouldn't we use a cloud-agnostic model?
There was a problem hiding this comment.
Not for this. This is a AWS playground only sample so it makes more sense to be clear that the model is AWS only. We will abstract this at the next step where we have a model on all platforms (likely llama or mistral).
There was a problem hiding this comment.
ai/llama3.2 is available on all clouds right? Why not use that?
There was a problem hiding this comment.
I am skeptical that an "AWS playground only sample" is reasonable
|
closing in favour of #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to remove some setting from compose. Use mode Id from Amazon for meaningful model name.
Samples Checklist
✅ All good!