Fix provider llm sample #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
jordanstephens
requested changes
May 20, 2025
samples/managed-llm/compose.yaml
Outdated
| environment: | ||
| - ENDPOINT_URL=http://llm/api/v1/chat/completions # endpoint to the gateway service | ||
| - MODEL=anthropic.claude-3-haiku-20240307-v1:0 # LLM model ID used for the gateway | ||
| - MODEL=us.amazon.nova-micro-v1:0 # LLM model ID used for the gateway |
There was a problem hiding this comment.
Let's use a cloud-agnostic model.
There was a problem hiding this comment.
so either a (hidden) default or llama or mistral. (Llama is cheaper than Mistral.)
There was a problem hiding this comment.
Yeah I think ai/llama3.2 is available everywhere
|
be mindful of changes in #378, where the whole |
commit111
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
commit111
reviewed
May 21, 2025
commit111
had a problem deploying
to
deploy-changed-samples
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
managed-llm-providersample to use the "generated" environment variables,<service>_URLand<service>_MODEL.This needs DefangLabs/defang#1194 to work.
Samples Checklist
✅ All good!