easymde: enable native/browser spell checker #12377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentijnscholten
force-pushed
the
easy-mde-native-spell-check
branch
from
7d57a6a to
ad5090d
Compare
|
This pull request introduces a potential Cross-Site Scripting (XSS) vulnerability in the EasyMDE markdown editor when using the 'inputStyle: contenteditable' configuration, which could allow malicious script injection if input is not properly sanitized. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
valentijnscholten
changed the title
Maffooch
approved these changes
May 16, 2025
dogboat
approved these changes
May 16, 2025
hblankenship
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12363
To make native spell checking work with EasyMDE text fields, we need to DISABLE spell checking on the field.
This was already done, but we also need to change the
inputStyletocontenteditable.This wasn't clear to a lot of people including me: Ionaru/easy-markdown-editor#617, for which I raised Ionaru/easy-markdown-editor#619
The change to
contenteditabledoesn't seem to have a noticable effect, I can still create/edit findings and other objects. Just to be safe I added it to 2.47.0 and not the first upcomingbugfixrelease.