-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Add SparkDex project slug to DefiLlama #16099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The adapter at projects/sparkdex exports TVL:
|
We need nonzero TVL to list on the TVL dashboard. If you want we can just make the slug without TVL? |
I submitted PR on yield-server, which will have TVL data for the SparkDEX (SPRK) token staking yield. Which failed the test case due to lack of slug. So, yes, please just make the slug without TVL here. Then the yield-server PR will pass the test. |
Can you send logo and other metadata in a comment on this PR. Please include this info: https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/pull_request_template.md |
I think we already sent these info when creating other SparkDEX sub projects. It's fine to re-send, but I don't want to overwirte what were already setup. |
You already have a project slug its sparkdex |
Did you just add ? Then how can I re-run the test for the yield server PR? It failed due to no sparkdex slug. |
So we already have dimension adapters for perps, v2, v3, v3.1 - what is this for? |
It doesnt seem necessary to create a new protocol just for your SPRK staking yield - can you add it to an existing adapter? |
Add SparkDex project slug to DefiLlama
Overview
This PR adds a minimal SparkDex adapter to establish the project slug in DefiLlama without providing specific TVL calculations.
Some SparkDEX sub projects are already added: perps, v2, v3, v3.1. This project is added to marke sure the protocol slug available for it's staking token SPRK yield data can be added in the yield-server.
What is SparkDex?
SparkDex is a decentralized exchange protocol built on the Flare Network, offering various DeFi services including AMM trading, concentrated liquidity pools, and perpetual futures trading.
Changes Made
New Adapter:
sparkdex/
projects/sparkdex/index.js
Technical Details
Adapter Structure
Features
sparkdex
as a recognized project in DefiLlamaPurpose
This minimal adapter serves as a foundation for:
Benefits
Testing
Verification
Related Information
Checklist
Notes
Protocol: SparkDex
Network: Flare
Category: Project Foundation