-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Adding Juris Protocol Lending Protocol #16832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The adapter at projects/jurisprotocol exports TVL: |
|
The adapter at projects/jurisprotocol exports TVL: |
|
The adapter at projects/jurisprotocol exports TVL: |
|
Error while running adapter at projects/jurisprotocol: |
|
Error while running adapter at projects/jurisprotocol: |
|
The adapter at projects/jurisprotocol exports TVL: |
|
Error while running adapter at projects/jurisprotocol: |
|
The adapter at projects/jurisprotocol exports TVL: |
|
Error while running adapter at projects/jurisprotocol: |
|
Error while running adapter at projects/jurisprotocol: |
|
The adapter at projects/jurisprotocol exports TVL: |
1 similar comment
|
The adapter at projects/jurisprotocol exports TVL: |
|
The adapter at projects/jurisprotocol exports TVL: |
|
In order to fetch the tvl ... I ll need my code to be merged for juris token I added as well the native coins I believe that's why tvl is 0 I ll run some locally test as well |
projects/helper/tokenMapping.js
Outdated
| }, | ||
| terra: { | ||
| 'uluna': { coingeckoId: 'terra-luna-classic', decimals: 6 }, | ||
| 'uusd': { coingeckoId: 'terraclassicusd', decimals: 6 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uluna and uusd mappings arent needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can see here https://coins.llama.fi/prices/current/terra:uusd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding support for juris here DefiLlama/defillama-server@0d0f536
projects/jurisprotocol/index.js
Outdated
|
|
||
| // fetch bank balances once per owner | ||
| let bank = []; | ||
| try { bank = await bankBalances(owner); } catch (e) { log('bankBalances failed', owner, e?.message ?? e); bank = []; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please no try/catch
| /** | ||
| * bankBalances via LCD (native tokens) | ||
| */ | ||
| async function bankBalances(address) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be some code duplication here with other places in the repo - could we consolidate it please?
|
Please complete the PR description with the metadata requested in https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/pull_request_template.md |
|
any juris token TVL should be exported as |
|
The adapter at projects/jurisprotocol exports TVL: |
|
The adapter at projects/jurisprotocol exports TVL: |
can you check now ? i updated tokenmapping . now i excluded juris from all contracts * since its owned by juris i stilll see no tvl price ? needs from your side to add juris ? also i believe this will detect other native coins right ? uluna /ustc |
|
{ making now as well treasury.js |
is it fine if i added on juris protocol folder or needs to be on treasury/jurisprotocol.js ? |
|
except if its also possible not to add treasury yet and do it later |
projects/helper/tokenMapping.js
Outdated
| // '0x83048f0bf34feed8ced419455a4320a735a92e9d': { coingeckoId: "ozonechain", decimals: 18 }, // was mapped to wrong chain | ||
| }, | ||
| terra: { | ||
| 'terra1vhgq25vwuhdhn9xjll0rhl2s67jzw78a4g2t78y5kz89q9lsdskq2pxcj2': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mapping isnt required, we already price it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i removed it
it should be in the same adapter file |
|
The adapter at projects/jurisprotocol exports TVL: |
ok i believe those are fixed now can you verify ? since treasury currently is blank wont fetch it |
|
Your |
|
Error while running adapter at projects/jurisprotocol: |
|
The adapter at projects/jurisprotocol exports TVL: |
yeah - i excluded JURIS token from vesting and staking to not count as a tvl - i dont have lunc or ustc yet on the contracts so i believe this is correct |
i believe i have all the codes it needs for juris to be listed