Conversation
📝 WalkthroughWalkthroughMultiple blockchain chain configurations ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The adapter at projects/moneyfi exports TVL: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
projects/moneyfi/index.js (1)
18-98: Add a deactivation hallmark to explain the TVL step-change.Lines 18–98 disable six chains at once, which will produce an abrupt TVL drop in charts. Add a dated
hallmarksentry inmodule.exportsso the change is explicitly documented for users.Proposed patch
module.exports = { ...chainExports, timetravel: true, + hallmarks: [ + ["2026-03-31", "Disabled Ethereum/BSC/Arbitrum/Optimism/Core/Soneium adapters"], + ], methodology: "TVL counts stablecoins in fundVault, dexBridgeVault, and all strategies contracts.", };Based on learnings: In DefiLlama adapters, when protocol activity changes in ways that affect reported TVL, hallmark annotations should be used to document the event date for chart interpretability.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@projects/moneyfi/index.js` around lines 18 - 98, Add a dated hallmark documenting the mass deactivation to the exported adapter config: update the module.exports object to include a hallmarks array (or append to existing hallmarks) containing an entry with the YYYY-MM-DD timestamp and a short message like "Disabled multiple chains (ethereum, bsc, arbitrum, optimism, core, soneium) — causes TVL step-change"; ensure this hallmark is alongside the existing exported symbols (e.g., the base/stablecoins config) so charts consuming the adapter will show the annotation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@projects/moneyfi/index.js`:
- Around line 18-98: Add a dated hallmark documenting the mass deactivation to
the exported adapter config: update the module.exports object to include a
hallmarks array (or append to existing hallmarks) containing an entry with the
YYYY-MM-DD timestamp and a short message like "Disabled multiple chains
(ethereum, bsc, arbitrum, optimism, core, soneium) — causes TVL step-change";
ensure this hallmark is alongside the existing exported symbols (e.g., the
base/stablecoins config) so charts consuming the adapter will show the
annotation.
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
If you would like to add a
volume/fees/revenueadapter please submit the PR here.Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
For updating listing info It is a different repo, you can find your listing in this file, you can edit it there and put up a PR
Please do not add new npm dependencies, do not edit/push
pnpm-lock.yamlfile as part of your changes(Needs to be filled only for new listings)
Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?
Summary by CodeRabbit