feat(nav): redesign navigation with collapsible sidebar system #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new sidebar context with collapse/pin functionality - Add hover-to-expand and keyboard shortcuts (Cmd/Ctrl+B) - Implement smooth transitions and backdrop overlay
- Replace flat navigation with hierarchical NavGroup/NavLink components - Add collapsible groups with disclosure states - Implement tooltips for collapsed sidebar items
- Redesign desktop nav with dynamic width (80px collapsed, 244px expanded) - Add logo variants for different states - Implement pinned pages with grouped display - Add resources section with proper visual hierarchy
- Refactor mobile menu to use new navigation components - Add consistent grouping and visual hierarchy - Improve mobile navigation layout and spacing
- Redesign metrics header with better visual hierarchy - Add breadcrumb display and improved action button - Update pinned metrics handling with consistent key usage
- Add dark/light theme logo variants - Create compact icon version for collapsed sidebar - Add Discord icon to icon set
- Reorganize pages.json with new Resources section - Add icons to navigation items - Improve tooltip component with better styling options
- Remove unused Bookmark import - Clean up navigation component structure
- Create new sidebar context with collapse/pin functionality - Add hover-to-expand and keyboard shortcuts (Cmd/Ctrl+B) - Implement smooth transitions and backdrop overlay
Contributor
|
nav looks super clean - great job! |
- Adjust opacity of legal footer text for improved visibility
Author
oh hey, thanks! let's see if it gets merged 🫡 |
- Remove toggle button and its associated functionality from the DesktopNav component - Maintain ThemeSwitch for improved layout consistency
- Update responsive class names for better consistency - Simplify label display based on expansion state - Add screen reader support for collapsed state
- Add new links to primary navigation - Improve Careers link formatting in resources section
- Remove console log for cleaner code - Consolidate navigation links into a single NavItems component with attention handling - Adjust padding and layout for improved visual consistency in various sections
- Create new sidebar context with collapse/pin functionality - Add hover-to-expand and keyboard shortcuts (Cmd/Ctrl+B) - Implement smooth transitions and backdrop overlay
* do not show suggestions on readonly * allow chart to be stackable * inline suggestions * update styles * update styles * update styles --------- Co-authored-by: mintdart <[email protected]>
* Fix chart * Fix classnames
* fix scatter n barchart etc * support rest * update styles --------- Co-authored-by: mintdart <[email protected]>
* suggestions loading n restore prompt if cancel * add download csv n fix suggestion loading * update styles * fix --------- Co-authored-by: mintdart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major UX Changes
Collapsible Sidebar Navigation [screenshots below]
Redesigned Navigation Structure
Enhanced Metrics Component
Mobile Navigation Updates
Technical Improvements
Navigation Architecture
navStructure.tswith typed navigation definitionsNavGroupandNavLinkcomponents with consistent behaviorNavCollapseContextfor managing disclosure statesSidebarContextfor global sidebar state managementPerformance Optimizations
Code Organization
Asset Management
Screens