-
Notifications
You must be signed in to change notification settings - Fork 311
enh: improves the token pnl page #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
hey @mintdart, is this PR good to be merged? I noticed you made a couple of changes |
|
date formatting is wrong, i selected september 1 to october 31 , but price chart shows from aug 31 to oct 30 end price is $108,300 in your PR on https://defillama.com/token-pnl?start=1756684800&end=1761868800 it is $110,045 |
I will look right into it, thanks! |
|
Good catch @mintdart, in production we do not include the end day (31st Oct), is this what we expect? I have pushed the changes to match the production logic. |
|
no, in production we do include 31st, start and end dates in calendar should match the dates on chart |
|
looks good, does the start price, end price, all time high match to the one's on https://defillama.com/token-pnl ? |
|
you can test if there's any issue with dates by setting your timezone to UTC+09:00 |











This PR adds a range of useful features to the Token PNL and a touch up on the existing styling to be more aligned with the theme.
Features added:
Before:

After:
Desktop
token-pnl-green-after-desktop.mov
Negative PNL State
Mobile
token-pnl-after-mobile.mov