Skip to content

feat: add compare button to protocol overview #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add compare button to protocol overview #2187

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
796d749
feat: add compare protocol button to protocol page
kanerep Oct 9, 2025
3ac1dac
use memo to get protocol url
kanerep Oct 9, 2025
b3ea1d4
only show icon on mobile and aria-label
kanerep Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion src/containers/ProtocolOverview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,22 @@ export const ProtocolOverview = (props: IProtocolOverviewPageData) => {
return formattedNum(value, true)
}

const compareProtocolsUrl = useMemo(() => {
// If this is a combined protocol with child versions, compare the child protocols
if (props.otherProtocols && props.otherProtocols.length > 1) {
const childProtocols = props.otherProtocols
.slice(1, 4)
.map((p) => `protocol=${encodeURIComponent(p)}`)
.join('&')
return `/compare-protocols?${childProtocols}`
}
// Otherwise, compare with top competitor if available
if (props.competitors?.length) {
return `/compare-protocols?protocol=${encodeURIComponent(props.name)}&protocol=${encodeURIComponent(props.competitors[0].name)}`
}
return `/compare-protocols?protocol=${encodeURIComponent(props.name)}`
}, [props.otherProtocols, props.competitors, props.name])

return (
<ProtocolOverviewLayout
isCEX={props.isCEX}
Expand Down Expand Up @@ -122,7 +138,17 @@ export const ProtocolOverview = (props: IProtocolOverviewPageData) => {
{props.token.symbol && props.token.symbol !== '-' ? (
<span className="mr-auto font-normal">({props.token.symbol})</span>
) : null}
<Bookmark readableName={props.name} />
<div className="flex items-center gap-2">
<BasicLink
href={compareProtocolsUrl}
className="flex cursor-pointer flex-nowrap items-center gap-2 rounded-md bg-(--btn-bg) px-3 py-2 text-xs text-(--text-primary) hover:bg-(--btn-hover-bg) focus-visible:bg-(--btn-hover-bg)"
aria-label="Compare protocols"
>
<Icon name="repeat" className="h-3 w-3" />
<span className="hidden sm:inline">Compare</span>
</BasicLink>
<Bookmark readableName={props.name} />
</div>
</h1>
<ProtocolTVL
hasTvl={props.metrics.tvl}
Expand All @@ -146,6 +172,14 @@ export const ProtocolOverview = (props: IProtocolOverviewPageData) => {
{props.token.symbol && props.token.symbol !== '-' ? (
<span className="mr-auto font-normal">({props.token.symbol})</span>
) : null}
<BasicLink
href={compareProtocolsUrl}
className="flex cursor-pointer flex-nowrap items-center gap-2 rounded-md bg-(--btn-bg) px-3 py-2 text-xs text-(--text-primary) hover:bg-(--btn-hover-bg) focus-visible:bg-(--btn-hover-bg)"
aria-label="Compare protocols"
>
<Icon name="repeat" className="h-3 w-3" />
<span className="hidden sm:inline">Compare</span>
</BasicLink>
<Bookmark readableName={props.name} />
</h1>
<ProtocolTVL
Expand Down