V2 Chain Assets #10820
V2 Chain Assets #10820
Conversation
defi/l2/adapters/ada.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import fetch from "node-fetch"; | |||
| import { cachedFetch } from "@defillama/sdk/build/util/cache"; | |||
There was a problem hiding this comment.
hmm, no. Lets not use this path @defillama/sdk/build/... in the future, once the sdk is published, you can get it via sdk.cache.cachedFetch
There was a problem hiding this comment.
Same for the runInPromisePool in the next file
There was a problem hiding this comment.
thanks - I'll change these when the SDK is out
defi/l2/adapters/ada.ts
Outdated
|
|
||
| export async function fetchAdaTokens(): Promise<any[]> { | ||
| const res = await fetch(`https://api.muesliswap.com/token-list`).then((r) => r.json()); | ||
| const res = await cachedFetch({key: "muesliswap-token-list", endpoint: "https://api.muesliswap.com/token-list"}) |
There was a problem hiding this comment.
You can skip the key here if you want, it gets computed from endpoint as hash if key is missing for get requests
defi/l2/excluded.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { getPrices } from "./utils"; | |||
| import { getPrices } from "@defillama/sdk/build/util/coinsApi"; | |||
There was a problem hiding this comment.
Can you check if this function works the same as the one you are replacing, also, same comment about using the build/..
The reason is, if something is not exposed by the SDK, we assume it is not used anywhere and can nuke it by mistake
There was a problem hiding this comment.
I've tested this here with the SDK branch and it works the same - I was planning on replacing the relevant code in other parts of the repo once the SDK changes have been released
defi/l2/tvl.ts
Outdated
| import { verifyChanges } from "./verifyChanges"; | ||
| import { getExcludedTvl } from "./excluded"; | ||
| import { saveRawBridgedTvls } from "./raw"; | ||
| import { getMcaps } from "@defillama/sdk/build/util/coinsApi"; |
There was a problem hiding this comment.
Hmm, this is not there in my sdk pr, but in yours?
| try { | ||
| process.env.TRON_RPC = process.env.TRON_RPC?.substring(process.env.TRON_RPC.indexOf(",") + 1); | ||
| await PromisePool.withConcurrency(2) | ||
| await PromisePool.withConcurrency(5) |
There was a problem hiding this comment.
editing tron config via env variable wont really work of provider object is already created and also, it is not really needed?
| const j = Object.keys(incomingAssets).indexOf(chain); | ||
| try { | ||
| const tokens: Address[] = j == -1 ? [] : await Object.values(incomingAssets)[j](); | ||
| const tokens: Address[] = incomingAssets[chain as keyof typeof incomingAssets] ? await incomingAssets[chain as keyof typeof incomingAssets]() : [] |
There was a problem hiding this comment.
one of the reasons why I hate typescript, it makes to code unreadable, no need to change, personally I prefer any over this
| async function fetchAllTokens() { | ||
| await initializePriceQueryFilter(); | ||
|
|
||
| whitelistedTokenSetRawPids.forEach((t) => { |
There was a problem hiding this comment.
why not build a chain level set from the start, instead of a common set, and then split by chain, only use of whitelistedTokenSetRawPids is here
No description provided.