-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Warp Finance Fees #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Warp Finance Fees #3932
Conversation
The WarpFinance adapter exports:
|
const fetch = async (options: FetchOptions) => { | ||
const dailyFees = options.createBalances(); | ||
const data: any[] = await options.getLogs({ | ||
target: WARPFeeCollector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Incorrect way to track the fees for Li.Fi wrappers. _integratorFee is the Fee for Li.FI so please fix that, or does Li.Fi charge same fee as integrator?
fees/WarpFinance/index.ts
Outdated
const methodology = { | ||
Fees: 'All fees paid by users for swap and bridge tokens via LI.FI.', | ||
Revenue: 'Fees are distributed to Warp Finance and creators', | ||
ProtocolRevenue: 'Fees are distributed to Warp Finance.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per the one of your tweet, it says 50% revenue will go to token creator and 50% to protocol, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason my VScode didnt save the changes. I have updated the repo with
import { FetchOptions, SimpleAdapter } from "../../adapters/types";
import { CHAIN } from "../../helpers/chains";
const FeeCollectedEvent = "event FeesCollected(address indexed _token, address indexed _integrator, uint256 _integratorFee, uint256 _lifiFee)"
const WARPFeeCollector = '0x312a6be6bD9850D6a2F793b8425c39eFC01C3585';
const fetch = async (options: FetchOptions) => {
const dailyFees = options.createBalances();
const data: any[] = await options.getLogs({
target: WARPFeeCollector,
eventAbi: FeeCollectedEvent,
});
data.forEach((log: any) => {
dailyFees.add(log._token, log._integratorFee);
});
return { dailyFees, dailyRevenue: dailyFees, dailyProtocolRevenue: dailyFees };
};
const methodology = {
Fees: 'There is no fees in creating tokens. Creators pay Network fees only.',
Revenue: 'Revenue is generated via V3 Uniswap buy/sell 50% creators & 50% to Warp Finance.',
ProtocolRevenue: 'V3 Trading Fees are distributed to Warp Finance.',
}
const adapter: SimpleAdapter = {
version: 2,
fetch,
chains: [CHAIN.ETHEREUM],
start: '2023-07-27',
methodology
}
export default adapter;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
The WarpFinance adapter exports:
|
Good day. We have changed the factory/fee address please update at your earliest convenience. Thank you |
The WarpFinance adapter exports:
|
|
||
const FeeCollectedEvent = "event FeesCollected(address indexed _token, address indexed _integrator, uint256 _integratorFee, uint256 _lifiFee)" | ||
|
||
const WARPFeeCollector = '0x86A74536f7C5548EFE9e935863eA7bE333380288'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no event named FeesCollected in the FeeCollector contract
converting to draft as no fee data is available or wrong implementation |
The WarpFinance adapter exports:
|
We have added Fees adapter for Warp Finance