Skip to content

Add: Aqua-network new data, move adapter to v2 #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add: Aqua-network new data, move adapter to v2 #4122

wants to merge 3 commits into from
+28 −20

Conversation

dry-cake
Copy link
Contributor

No description provided.

@llamabutler
Copy link

The aqua-network adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs aqua-network

🦙 Running AQUA-NETWORK adapter 🦙
---------------------------------------------------
Start Date:	Thu, 28 Aug 2025 11:46:52 GMT
End Date:	Fri, 29 Aug 2025 11:46:52 GMT
---------------------------------------------------

STELLAR 👇
Backfill start time: 1/7/2024
Daily volume: 760.86 k
Daily fees: 964
Daily revenue: 482
Daily protocol revenue: 0
End timestamp: 1756468011 (2025-08-29T11:46:51.000Z)

@g1nt0ki g1nt0ki self-assigned this Aug 29, 2025
@llamabutler
Copy link

The aqua-network adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs aqua-network

🦙 Running AQUA-NETWORK adapter 🦙
---------------------------------------------------
Start Date:	Thu, 28 Aug 2025 00:00:00 GMT
End Date:	Fri, 29 Aug 2025 00:00:00 GMT
---------------------------------------------------

STELLAR 👇
Backfill start time: 1/7/2024
Daily volume: 760.86 k
Daily fees: 964
Daily holders revenue: 482
Daily revenue: 482
Daily protocol revenue: 0

@llamabutler
Copy link

The aqua-network adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs aqua-network

🦙 Running AQUA-NETWORK adapter 🦙
---------------------------------------------------
Start Date:	Thu, 28 Aug 2025 00:00:00 GMT
End Date:	Fri, 29 Aug 2025 00:00:00 GMT
---------------------------------------------------

STELLAR 👇
Backfill start time: 1/7/2024
Daily volume: 760.86 k
Daily fees: 964
Daily supply side revenue: 482
Daily revenue: 482
Daily holders revenue: 482
Daily protocol revenue: 0

g1nt0ki
g1nt0ki requested changes Aug 29, 2025
View reviewed changes
Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

dexs/aqua-network/index.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dry-cake thanks for the PR but I have reverted it back to use version 1 because, the api returns daily data not for a arbitrary time range (per-requsite for v2 adapters)

dexs/aqua-network/index.ts
date: string;
protocol_fees: number;
lp_fees: number;
external_rewards: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this field and why is counted as fees?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, whats the difference between protocol fees & lp fees? do the LPs get aqua rewards on top of the swap fees or instead of the swap fees?

Also, can you please add the "methodology" field 🙏

Copy link
Contributor Author

@dry-cake dry-cake Aug 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we can add timestamps range from - to for each day, it's only restriction from moving to v2?
It should be unixtime timestamp, right?

Copy link
Contributor Author

@dry-cake dry-cake Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g1nt0ki ^ 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, unix timestamp in seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1nt0ki g1nt0ki g1nt0ki requested changes

Assignees

@g1nt0ki g1nt0ki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dry-cake @llamabutler @g1nt0ki