Nordstern-Finance aggregator adapter: added volume metrics for all su… #4548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The nordstern-finance adapter exports: |
|
@chupchup325 can we keep static chain names to keep historical data incase chain is removed/disabled and other issues because now we rely on API for all chain names. |
|
hi @treeoflife2, i can change the adapter to:
By creating a backup of the chains enum and then merging the helpers/chains enum into it. That way we keep the historical data for the currently supported changes and automatically add newly supported ones. Let me know what you think, so i can go ahead and create the necessary changes. |
that sounds good |
|
The nordstern-finance adapter exports: |
|
@treeoflife2 bespoken changes have been pushed |
|
@chupchup325 can you remove the 0 volume chains, reasone being it will only slow the execution of the adapter without adding any value, as i can see only few chains are contributing to the volume. and please don't merge all the chains from the helper as that's bad practice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
added volume metrics for all supported chain by nordstern.finance
Name (to be shown on DefiLlama):
Nordstern.Finance
Twitter Link:
https://x.com/nordstern_fi
Website Link:
https://nordstern.finance/
Logo (High resolution, will be shown with rounded borders):
https://pbs.twimg.com/profile_images/1958851814683557888/WvwjwXf9_400x400.jpg