Add Clickhouse Client #4602
Open
Add Clickhouse Client #4602
+206
−4,406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1nt0ki
reviewed
Nov 5, 2025
package-lock.json
Outdated
g1nt0ki
reviewed
Nov 5, 2025
| 'DUNE_BULK_MODE', | ||
| 'DUNE_BULK_MODE_BATCH_TIME', | ||
| 'LLAMA_HL_INDEXER', | ||
| 'CLICKHOUSE_HOST', |
There was a problem hiding this comment.
I prefer a single env var, can be a json string, check what we are doing in server repo
g1nt0ki
reviewed
Nov 5, 2025
There was a problem hiding this comment.
wondering if should move this to @defillama/sdk repo
this way, code is not repeated
g1nt0ki
reviewed
Nov 5, 2025
| } | ||
| } | ||
|
|
||
| export async function disconnectClickhouse() { |
There was a problem hiding this comment.
please add auto disconnect on exit event
|
@0xpeluche can we move helper function to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.