Skip to content

Fix opensea seaport#5825

Merged
noateden merged 1 commit intoDefiLlama:masterfrom
FelixBruguera:seaport-fix
Feb 6, 2026
Merged

Fix opensea seaport#5825
noateden merged 1 commit intoDefiLlama:masterfrom
FelixBruguera:seaport-fix

Conversation

@FelixBruguera
Copy link
Contributor

@FelixBruguera FelixBruguera commented Feb 6, 2026

Fixed a mistake on opensea seaport that overcounted the fees

Summary by CodeRabbit

  • Bug Fixes
    • Refined OpenSea Seaport fee calculation to exclude the largest recipient's share from fee aggregates, improving accuracy of platform fee and revenue metrics.

@llamabutler
Copy link

The opensea adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees opensea

🦙 Running OPENSEA adapter 🦙
---------------------------------------------------
Start Date:	Thu, 05 Feb 2026 11:46:59 GMT
End Date:	Fri, 06 Feb 2026 11:46:59 GMT
---------------------------------------------------

------ ERROR ------
Error: Breakdown adapters are deprecated, migrate it to use simple adapter
    at /home/runner/work/dimension-adapters/dimension-adapters/cli/testAdapter.ts:89:60
Breakdown adapters are deprecated, migrate it to use simple adapter

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Seaport fee parsing logic now includes an early exit in the recipients loop to skip the recipient with the largest consideration amount, excluding their share from dailyFees, dailyRevenue, and dailySupplySideRevenue aggregations.

Changes

Cohort / File(s) Summary
Seaport Fee Parsing
fees/opensea/seaport.ts
Added conditional early exit in recipients loop to skip processing for the largest consideration recipient, excluding their metrics from fee, revenue, and supply-side revenue aggregations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A skip, a bound through the loop we go,
The biggest one won't steal the show,
With logic swift and fees below,
We hop around with careful flow! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix opensea seaport' is vague and generic, lacking specificity about what mistake was fixed or the nature of the fee-related issue being addressed. Provide a more specific title that describes the actual fix, such as 'Fix OpenSea Seaport fee overcounting issue' or 'Exclude largest recipient from fee aggregates in Seaport'.
Description check ❓ Inconclusive The pull request description is minimal and does not follow the repository template structure; it only provides a brief statement without detailed explanation of the fix. Expand the description to explain why the fix was needed, what the root cause was, and how the change resolves the overcounting issue for clarity.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@noateden noateden merged commit 75be0af into DefiLlama:master Feb 6, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants