fix(genius-protocol): swallow transient errors to prevent failed day …#6288
Closed
brihu23 wants to merge 2 commits intoDefiLlama:masterfrom
Closed
fix(genius-protocol): swallow transient errors to prevent failed day …#6288brihu23 wants to merge 2 commits intoDefiLlama:masterfrom
brihu23 wants to merge 2 commits intoDefiLlama:masterfrom
Conversation
…fetches
- fees: wrap getETHReceived and getSolanaReceived in try/catch so Allium
timeouts/errors dont
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughError handling enhancements added to two genius-protocol modules. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The genius-protocol adapter exports: |
|
The genius-protocol adapter exports: |
bheluga
reviewed
Mar 29, 2026
Member
There was a problem hiding this comment.
@brihu23 thanks for the PR.
Its ok for errors to be thrown as we get notification on failure, if we catch errors it would get ignored.
Also wrt allium errors, we have API key in prod, so this error isnt an issue
Let me know if your intention was something else
Contributor
Author
Hi @bheluga, thank you! We have a few missing days this last month on fees + volume and were aiming to start the data from ~Jan 10th. What would you suggest is the best way to resolve this? Thank you!
|
Member
Contributor
Author
|
@bheluga We had a 0 fees promo during that period and were about to turn on fees so people were using platform heavily to get last bit of free points https://dune.com/geniusterminal/geniusdata https://www.theblock.co/post/385366/yzi-labs-invests-genius-trading-cz-advisor |
Member
Well, if you can query volume onchain, that would be much better as it would be highly transparent over api. |
Contributor
Author
|
Hi @bheluga, we'll be deploying a router shortly that should help with this! |
|
The genius-protocol adapter exports: |
|
The genius-protocol adapter exports: |
Member
I have started refilling fees for missing days, allium adapters are bit slow compared to others, so will take some time |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fetches
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package.json/package-lock.jsonfile as part of your changesName (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?
Summary by CodeRabbit