Support P256 network curve in API calls #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmaguire
changed the title
brad-defined
previously approved these changes
Dec 5, 2024
Code reorgnization allows dnapitest to import the marshal/unmarshal functions from the keys package.
brad-defined
previously approved these changes
Dec 5, 2024
brad-defined
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #17.
This PR adds PrivateKey, PublicKey, and TrustedKey types for handling host keys and CA keys. dnapi will always send both P256 and Ed25519 keys with enrollment requests. From that point forward, dnapi will only generate keys of the type used in prior requests.
dnapi does not attempt to "filter" trusted keys to only the curve supported by Nebula. In other words, a P256 network requires P256 CAs and host keys, but does not necessarily require P256 trusted keys. Do we want to add enforcement here?
Some code was moved into a
keyssub-package in order to allowdnapitestto import it, while still allowing thednapipackage to importdnapitest. The bulk of this code is tested through a call to DoUpdate.