Skip to content

Add deprecated pill to deprecated firewall config item #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasikpark wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add deprecated pill to deprecated firewall config item #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/config/firewall.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ enabling the built-in Nebula SSH server, you may wish to grant access over the N
## firewall.default_local_cidr_any

<Pill className="mb-24">Default: False</Pill> <Pill className="mb-24">Reloadable</Pill>
{/** children passed as prop to avoid MDX generating a paragraph inside Pill */}
<Pill className="mb-24" variant="warning" children="Deprecated" />

This setting was introduced in Nebula v1.9.0 set to `true` for backwards compatibility purposes. The default was changed
to `false` in Nebula v1.10.0 and the config option is now deprecated.
Expand Down
9 changes: 7 additions & 2 deletions src/components/Pill/Pill.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,20 @@
font-weight: 600;
line-height: 1;
border-radius: 10rem;
background-color: var(--ifm-color-emphasis-200);
padding: 4px 8px;

&:global(.no-transform),
& :global(.no-transform) {
&:global(.no-transform) {
text-transform: none;
}
}

.Pill___info {
color: var(--ifm-color-secondary-contrast-foreground);
background-color: var(--ifm-color-secondary-contrast-background);
}

.Pill___warning {
background-color: var(--ifm-color-warning-contrast-background);
color: var(--ifm-color-warning-contrast-foreground);
}
2 changes: 1 addition & 1 deletion src/components/Pill/Pill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styles from './Pill.module.css';
type Props = {
children: React.ReactNode;
className?: string;
variant?: 'info';
variant?: 'info' | 'warning';
};

export function Pill({ children, className, variant = 'info' }) {
Expand Down