Skip to content

Conversation

@DefinetlyNotAI
Copy link
Owner

@DefinetlyNotAI DefinetlyNotAI commented Nov 20, 2024

Pull Request Template

Prerequisites

  • I have searched for duplicate or closed issues.
  • I have read the contributing guidelines.
  • I have followed the instructions in the wiki about contributions.
  • I have updated the documentation accordingly, if required.
  • I have tested my code with the --dev flag, if required.

PR Type

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
    update
  • ⚠️ Breaking change ⚠️

Description

Just did part of the PLANS.md

Refactored redocumented some code, and optimised imports as well as fixed a minor bug

Motivation and Context

Part of the PLANS.md

Credit

N/A

Issues Fixed

N/A

Forgot to add the main() runner, now its fixed
The _health.py, _hide_my_tracks.py and _zipper.py have been moved to Logicytics.py, this is to make it easier to maintain
Optimised imports, and docstrings some functions, and reformatted some code
@DefinetlyNotAI DefinetlyNotAI self-assigned this Nov 20, 2024
@pull-request-size pull-request-size bot added the size/XL Huge size pr label Nov 20, 2024
@DefinetlyNotAI DefinetlyNotAI added type/Documentation Improvements or additions to commentations type/Code Related to the Code part bug/Low Something isn't working, it's simple though. request/Minor New feature or request, not important, may not do labels Nov 20, 2024
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ba82824 and detected 0 issues on this pull request.

View more on Code Climate.

@DefinetlyNotAI DefinetlyNotAI merged commit 8a1c6f0 into main Nov 20, 2024
@DefinetlyNotAI DefinetlyNotAI deleted the docstring-everything-again-v2.4.2 branch November 20, 2024 07:45
DefinetlyNotAI added a commit that referenced this pull request Sep 18, 2025
## Pull Request Template

### Prerequisites

<!-- Take a couple of minutes to help our maintainers work faster by
checking of the pre-requisites. -->
<!-- To tick the checkboxes replace the space with an 'x', so [ ]
becomes [x] . -->

- [x] I have
[searched](https://github.com/DefinetlyNotAI/Logicytics/pulls) for
duplicate or closed issues.
- [x] I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md).
- [x] I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) about
contributions.
- [x] I have updated the documentation accordingly, if required.
- [x] I have tested my code with the `--dev` flag, if required.

### PR Type

<!-- Take a couple of minutes to help our maintainers work faster by
telling us what is the PR guided on. -->
<!-- To tick the checkboxes replace the space with an 'x', so [ ]
becomes [x] . -->

- [x] Bug fix <!-- Non-Breaking Bug Fix - Usually relates to fixing an
issue -->
- [ ] New feature <!-- Non-Breaking Change that adds a new feature -->
- [x] Refactoring <!-- Non-Breaking Change that modifies existing code
to refactor it to become more organised -->
- [ ] Documentation
update <!-- Non-Breaking Change that modifies existing documentation to
refactor it or add extra comments - either wiki, md files or code is
included here -->
- [ ] ⚠️ Breaking change ⚠️ <!-- Breaking Bug Fix / New Addition that
changes how Logicytics works -->

### Description

<!-- REQUIRED: Provide a summary of the PR and what you expected to
happen. -->
Just did part of the PLANS.md

Refactored redocumented some code, and optimised imports as well as
fixed a minor bug

### Motivation and Context

<!-- REQUIRED: Why is this PR required? What problem does it solve? Why
do you want to do it? -->
Part of the PLANS.md

### Credit

<!-- If this PR is a contribution, please mention the contributors here
using the appropriate syntax. -->

<!--
### File-Created/CONTRIBUTION by MAIN-Username
What you did, created, removed, refactored, fixed, or discovered.
- [Your GitHub Username](https://github.com/YourGitHubLink)
- [Your GitHub Username](https://github.com/YourGitHubLink) etc...
-->
_N/A_

### Issues Fixed

<!-- REQUIRED: What issues will be fixed? (Format: "#50, #23" etc.) if
none exist type _N/A_ -->
_N/A_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug/Low Something isn't working, it's simple though. request/Minor New feature or request, not important, may not do size/XL Huge size pr type/Code Related to the Code part type/Documentation Improvements or additions to commentations

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants